This repository was archived by the owner on Mar 4, 2025. It is now read-only.
SUP-1447, peer review updates #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
September 22, 2015 13:03
Cherry picked changes for following commits into peer-review app 1) Added support for comment in review scorecard Commit: b98faebde93fa8a4d55ea26f594370966ed2b2f8 [b98faeb] Parents: 85a1d5da43 Author: vikasrohit <[email protected]> Date: 28 July 2015 6:23:02 pm IST 2) adapting for array of comments in api requests and responses Commit: deac3d7b57b8627f9fccb97af2034671ca8ddf87 [deac3d7] Parents: b98faebde9 Author: vikasrohit <[email protected]> Date: 29 July 2015 5:06:34 pm IST Labels: vikas-scorecard-comment-support
Cherry picked changes for following commits into peer-review app 1) integrating with api Commit: da21a311e76083e8a2cc35b4135c9e16c3c1247d [da21a31] Parents: deac3d7b57 Author: Mauricio Desiderio <[email protected]> Date: 1 August 2015 1:36:12 am IST Labels: origin/vikas-scorecard-comment-support
Cherry picked changes for following commits into peer-review app 1) integrating with api Commit: da21a311e76083e8a2cc35b4135c9e16c3c1247d [da21a31] Parents: deac3d7b57 Author: Mauricio Desiderio <[email protected]> Date: 1 August 2015 1:36:12 am IST Labels: origin/vikas-scorecard-comment-support
Cherry picked changes for following commits into peer-review app 1) Initialize comment as an empty string, refactor helper logic Commit: 3ca3272666c64aa4dba072d41223dd7ed53b6f41 [3ca3272] Parents: b9669d651b Author: Nick Litwin <[email protected]> Date: 1 August 2015 2:58:10 am IST Labels: HEAD origin/dev origin/HEAD dev
Cherry picked changes for following commits into peer-review app Converted coffee syntax to javascript
Cherry picked changes for following commits into peer-review app 1)Update routes to work with new backend Commit: 85a1d5da43f1339c1f517ed2af20fe674bad20e2 [85a1d5d] Parents: 58e6f391a4 Author: Nick Litwin <[email protected]> Date: 24 July 2015 2:59:41 am IST
Used v2 for challenge details end point.
|
We should merge this and test it soon :D |
added 4 commits
October 1, 2015 10:54
Fixed review service API calls to use v2 token instead of v3 token.
* dev: (178 commits) SUP-1775 Do not remove the old rev files until we figure out a better way to keep nginx in sync Refactored NaN fix fixed srm NaN display fixes activity section Fix layout and hover states of external links fixing weird currency problem more fixes Use new spinner Fixed error div width for mobile view Fix layout of external tiles empty state and default state changes Added default icon Added link to home page for reg flow header logos Fixed header position for register successfully page for mobile view SUP-1724, no message for log in if the account is unactivated SUP-1724, no message for log in if the account is unactivated fix competitive programming link reverting close mobile nav on state change to handle link behavior fixing safari redirect Fixed header position for register page ... Conflicts: app/services/challenge.service.js
-- Removed using v2 tokens for the review end points.
-- Removed logic for supporting compatibility with v2 tokens.
vikasrohit
pushed a commit
that referenced
this pull request
Oct 15, 2015
…-review-updates SUP-1447, peer review updates @parthshah @nlitwin @tladendo @mdesiderio merging
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@parthshah @nlitwin @mdesiderio fyi