Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Done button made active on page dirty instead of only communities #1238

Merged
merged 1 commit into from
Oct 17, 2017
Merged

Done button made active on page dirty instead of only communities #1238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/skill-picker/skill-picker.controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ import _ from 'lodash'
}
promises.push(ProfileService.updateUserSkills(vm.username, data))
}
logger.debug('isCommunitiesDirty: ' + isCommunitiesDirty())

if (isCommunitiesDirty()) {
for(var communityName in vm.communities) {
var community = vm.communities[communityName]
Expand Down
2 changes: 1 addition & 1 deletion app/skill-picker/skill-picker.jade
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,4 +74,4 @@
type="button",
tc-busy-button, tc-busy-when="vm.saving",
ng-click="vm.submitSkills()",
ng-disabled="vm.disableDoneButton || !vm.isCommunitySelected()") Done
ng-disabled="vm.disableDoneButton || !vm.isPageDirty()") Done