This repository was archived by the owner on Mar 4, 2025. It is now read-only.
Integrated new challenges API w/ mock data #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| challenge-tile(challenge="challenge", domain="vm.domain") | ||
| .challenge.tile(ng-repeat="challenge in vm.pastChallenges = (profileVm.pastChallenges)") | ||
| challenge-tile(challenge="challenge", domain="vm.domain", view="'tile'") | ||
| //.challenge.tile(ng-repeat="challenge in vm.pastChallenges = (profileVm.pastChallenges | filter: {'track': vm.track, 'subTrack': vm.subTrack})") |
There was a problem hiding this comment.
this is only until APIs are available
|
This isn't ready to merge...still using mock data, and the API is ready now. Still, leave comments if you have any, because the code is still pretty much there. |
tladendo
added a commit
that referenced
this pull request
Aug 20, 2015
Integrated new challenges API w/ mock data
| .challenge.tile(ng-repeat="challenge in vm.pastChallenges = (profileVm.pastChallenges | filter: {'track': vm.track, 'subTrack': vm.subTrack})") | ||
| challenge-tile(challenge="challenge", domain="vm.domain") | ||
| .challenge.tile(ng-repeat="challenge in vm.pastChallenges = (profileVm.pastChallenges)") | ||
| challenge-tile(challenge="challenge", domain="vm.domain", view="'tile'") |
There was a problem hiding this comment.
I think we can remove domain="vm.domain" here, since the challenge-tile directive does $scope.DOMAIN = CONSTANTS.domain;
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fyi @parthshah @nlitwin