Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

[$10] - Inconsistent top menu in various sections of the site, and also with different window size #952

Closed
birdofpreyru opened this issue Jan 25, 2017 · 5 comments · Fixed by topcoder-archive/appirio_tech-tc-site#463 or #964
Assignees

Comments

@birdofpreyru
Copy link
Collaborator

birdofpreyru commented Jan 25, 2017

See the screenshot, and the last comment in the thread.

@birdofpreyru
Copy link
Collaborator Author

@ajefts

I've noticed that the top menu for the narrow screen at the dashboard page (i.e. the one served by topcoder-app) contains a whole section of links missing in all other reincarnations of the top menu (wide screen from topcoder-app and both narrow and wide screen ones from tc-site):
screen-4

First, I want to check with you, whether it (1) was intended to be added everywhere, but somebody forgot to add it in all instances of the menu, or (2) was it intended to be removed, and somebody forgot to remove it from one of the places?

If (1), then to add these missing links to the widescreen menus, we'll need icons for these menu items.

@ajefts
Copy link
Contributor

ajefts commented Jan 27, 2017

I think that was intentional since those links are in the footer...

@birdofpreyru
Copy link
Collaborator Author

Expected Fix

This is a pretty easy one:

  1. Remove this section from the narrow-screen menu (it is in this repo).
  2. Ensure that the spacing between the last item in the menu (which will be Blog now) and the bottom of the grey background of the dropdown menu remains nice.
  3. Check the menu at the challenge listing page (that menu is shown by the code in https://github.com/appirio-tech/tc-site), you'll see that there is no spacing between the last item in the menu, and its bottom border. Please fix it, so that both versions of the menu, served from different apps, do look like the same nice menu.

@birdofpreyru birdofpreyru changed the title Inconsistent top menu in various sections of the site, and also with different window size [$10] - Inconsistent top menu in various sections of the site, and also with different window size Jan 27, 2017
@shubhendusaurabh shubhendusaurabh self-assigned this Jan 28, 2017
@shubhendusaurabh
Copy link
Contributor

@birdofpreyru Please elaborate on 2nd and 3rd requirements.
This is what the menu's are in app and site repos.

So, I need to match tc-site menu to topcoder-app menu? Add bottom padding in tc-site menu?

@birdofpreyru
Copy link
Collaborator Author

@shubhendusaurabh yes, the should be some bottom padding, the same in both repos. Now it is absent in tc-site

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants