[$20] - Documents attached to challenge page are not visible once the submission phase is over

[Jaouad-Jaghrir]

Once the submission phase is over, the documents attached under the "Downloads" section of a challenge details page are not available for download. it shows the following message "Downloads are no longer available for this challenge".

So, a reviewer needs to download the documents during the submission phase.

If a reviewer is assigned after the end of the submission phase, he/she will not be able to access the documents attached in the challenge details page.

[talesforce]

@Schpotsky - This has always worked like this in the past as well. I will discuss with @ajefts if we intend to change this behaviour.

[birdofpreyru]

@ajefts Should we change it so that Downloads stay available till the end of the review phase?

[ajefts]

We can actually change it so they are available until the end of appeals response, or end of review if there is no appeals. However, these are not public attachments, so it should still be limited based on having a role on the challenge. I believe the current API should be checking that already.

[birdofpreyru]

Expected Fix

1. The code with challenge details page is hosted in this repo: https://github.com/appirio-tech/tc-site
2. The primary goal is to ensure that attachments under the Downloads section (see the screenshot below) of a challenge details page are visible for the logged in and registered for the challenge users, from the moment the challenge is open till the moment the challenge is completed.
3. Also revise and improve the overall logic related to this link. Now, it looks like some unnecessary checks are done in the conditions in some cases, and not accurate messages are shown in other cases (e.g. the Downloads are no longer available for this challenge message is also shown for drafted challenges, which have not been started yet).

[shubhendusaurabh]

topcoder-archive/appirio_tech-tc-site/pull/460