Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

[$30] - Add Predix badges to profiles #912

Closed
ajefts opened this issue Dec 15, 2016 · 5 comments · Fixed by #953
Closed

[$30] - Add Predix badges to profiles #912

ajefts opened this issue Dec 15, 2016 · 5 comments · Fixed by #953
Assignees

Comments

@ajefts
Copy link
Contributor

ajefts commented Dec 15, 2016

No description provided.

@ajefts
Copy link
Contributor Author

ajefts commented Jan 3, 2017

@talesforce Let's chat about this one tomorrow. I'd like to get this going relatively soon. It involves adding a couple new badges to the existing badge framework.

@ajefts
Copy link
Contributor Author

ajefts commented Jan 11, 2017

Here are the images for the badges.

tc-predix-community-badge.zip

@talesforce Can we get these added to the current sprite for the badges and get the profile page updated so it uses the new sprite? These badges should show up like the other badges do on the profile page.

We will be adding the data for the badge assignment separately, so you can assume that part is done.

@birdofpreyru
Copy link
Collaborator

@ajefts Do you mean by badges the image shown in the Skills section of the Profile page? It looks to me, there is no sprite for those, they are just stored and served as separate .svg images.

@ajefts
Copy link
Contributor Author

ajefts commented Jan 18, 2017

Thanks for jumping in @birdofpreyru . This is one we need to get done soon.

I'm referring to the badge modal you see if you click "Badges" under your profile pic:

image

I believe it uses sprites like these: https://github.com/appirio-tech/topcoder-app/blob/dev/assets/images/badge.grid.large.png

So, we need to get the sprite updated and the code logic that defines which badge to display based on the given badge id.

@dmessing Do you have your scripts handy for manually assigning badges? Can you attach them here please?

@birdofpreyru
Copy link
Collaborator

birdofpreyru commented Jan 18, 2017

Expected Fix:

  1. Add provided Predix Badge (https://github.com/appirio-tech/topcoder-app/files/699268/tc-predix-community-badge.zip) to the sprite (https://github.com/appirio-tech/topcoder-app/blob/dev/assets/images/badge.grid.large.png)

  2. For testing, mock the badges of the test user in the locally deployed App:
    In /app/services/user.service.js add after the line 5:
    import { getMockUserProfile } from '../../tests/test-helpers/mock-data.js'
    and change the getV2UserProfile function into:

    function getV2UserProfile(handle) {
      var profile = getMockUserProfile().data;
      profile.Achievements.push({
        date: "2017-01-01T00:00:00.000-04:00",
        description: "Predix Coder",
      });
      return Promise.resolve(profile);
    }
  1. Make any necessary modifications in other code, to ensure that Predix badge is properly displayed in the Badges modal of the user profile.

  2. Revert the changes done for testing (2) before submitting PR.

@birdofpreyru birdofpreyru changed the title Add Predix badges to profiles [$30] - Add Predix badges to profiles Jan 19, 2017
@birdofpreyru birdofpreyru removed their assignment Jan 24, 2017
@shubhendusaurabh shubhendusaurabh self-assigned this Jan 25, 2017
shubhendusaurabh added a commit to shubhendusaurabh/topcoder-app that referenced this issue Jan 25, 2017
shubhendusaurabh added a commit to shubhendusaurabh/topcoder-app that referenced this issue Jan 27, 2017
birdofpreyru added a commit that referenced this issue Jan 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants