[$20] - Changes for buttons at the Challenge Details page

[birdofpreyru]

Check the ticket #1040 and the corresponding PR topcoder-archive/appirio_tech-tc-site#480. We have re-factored the code behind user actions button at the Challenge Details page for Design track (those Register, Unregister, Submit, etc. buttons).

Under this ticket I want:

1. To make similar changes for similar buttons at Design track. Inside the HTML template buttons for the both page will be handled by the same simple template we already have, while description and logic behind the buttons for Design page should be moved into the controller, inside initButtons().

2. Use the ability to check for user roles (see the ticket [$40] - Preparing for role-dependent customization of the challenge details page #1002 and the corresponding PR TC App Issue 1002: role-dependent customization of the challenge details page appirio_tech-tc-site#479) to make the following changes to the buttons logic:

Unregister and Complete Appeals buttons (Dev track) should be shown only when user has Submitter role.

If user has any role beside Submitter, we should always show him the active View Scorecards button.

[rushikesh90]

I want to work on this

[rushikesh90]

So I may be missing something but "similar changes for similar buttons at Design track" do you mean the earlier changes are not there or you are referring to some other track?
Can you extend the time for bug bash as there is very little time left

[birdofpreyru]

Check the HTML template. Originally it had two large if sections. One was producing the buttons for the page with a Design challenge, and another for the page with a Development challenge. In that previous ticket and PR we have refactored the Development buttons, not touching the other branch of that if in the template.

Now we should get rid of that if in the template, just using the same new button template (which renders an array of buttons provided by controller, using ng-repeat) in both cases. Inside the controller, you should add all those buttons from the Design page, and all corresponding logic, into the function which generates the array of buttons, in the way it is done currently for the Development page buttons. + those role-based additions to the logic.

Can you extend the time for bug bash as there is very little time left

Don't worry about it. If you don't complete it time till the moment we process payments for this Bug Bash, we just roll it over to the next Bug Bash (our plan is to have them running quite regularly). Sure, if something changes in our plans, or the next Bug Bash delays for too much time, we can always handle your payment for this ticket separately.

[birdofpreyru]

@rushikesh90 Any news on this one? I am preparing to start another Bug Bash this weekend. If you are not interested in this ticket anymore, I'll open it for that Bug Bash.

[rushikesh90]

Ok Sure you can open this for bug bash. I had some system problem.

[shubhendusaurabh]

@birdofpreyru Is userrole method working? I get undefined while debugging.
Also if a user has submitted unregister button is useless as there is check in controller which does not allow a submitter to unregister.

[birdofpreyru]

@shubhendusaurabh

Also if a user has submitted unregister button is useless...

You are right, if user has submitted, we should not show the Unregister button. I believe in current implementation it is checked already, but it is not hidden, just disabled. Let's hide it. Though, the main focus here is that if user has no Submitter role, we should not show the button at all.

Is userrole method working?

Well, as I have accepted the fix which implemented it, I believe, I has checked and it looked functional to me. Though, probably I have overlooked something. Anyway, if there are any issues with the method, they should be fixed.