SUP-2481, intergrate-web-links-api

-- More unit tests
-- Fixed removeLink method in externalLinks.service.js

Author: vikasrohit

app/services/externalAccounts.service.spec.js

@@ -7,7 +7,7 @@ describe('ExternalAccount Service', function() {
   var mockProfile = mockData.getMockProfile();
   var apiUrl;
   var auth0, userService;
-  var profilePost, profileDelete;
+  var profileGet, profilePost, profileDelete;
 
 
   beforeEach(function() {
@@ -46,9 +46,10 @@ describe('ExternalAccount Service', function() {
     $httpBackend
       .when('GET', apiUrl + '/members/test1/externalAccounts/')
       .respond(200, {result: {content: mockAccountsData}});
-    $httpBackend
-      .when('GET', apiUrl + '/users/111/?fields=profiles')
-      .respond(200, {result: {content: mockUserLinksData}});
+
+    profileGet = $httpBackend.when('GET', apiUrl + '/users/111/?fields=profiles');
+    profileGet.respond(200, {result: {content: mockUserLinksData}});
+
     profilePost = $httpBackend.when('POST', apiUrl + '/users/111/profiles/');
     profilePost.respond(200, {result: {content: mockProfile}});
 
@@ -104,6 +105,33 @@ describe('ExternalAccount Service', function() {
     $httpBackend.flush();
   });
 
+  it('should not return unsupported links even if they are returned by the API', function() {
+    var profiles = JSON.parse(JSON.stringify(mockUserLinksData));
+    profiles.profiles.push({providerType: 'unsupported'});
+    profileGet.respond(200, {result: {content: profiles}});
+    // spy
+    service.getAllExternalLinks('test1', 111, true).then(function(data) {
+      expect(data).to.be.defined;
+      expect(_.pluck(data, 'provider')).to.include.members(['dribbble', 'github','bitbucket', 'stackoverflow']);
+      expect(_.all(_.pluck(data, 'data'))).to.be.truthy;
+    });
+    $httpBackend.flush();
+  });
+
+  it('should fail in returning links', function() {
+    var errorMessage = "bad request";
+    // mocks the GET call to respond with 400 bad request
+    profileGet.respond(400, {result:  { status: 400, content: errorMessage } });
+    // calls getAllExternalLinks method with valid params
+    service.getAllExternalLinks('test1', 111, true).then(function(data) {
+      sinon.assert.fail('should not be called');
+    }).catch(function(resp) {
+      expect(resp).to.exist;
+      expect(resp.status).to.exist.to.equal(400);
+    });
+    $httpBackend.flush();
+  });
+
   it('should link external account', function() {
     // call linkExternalAccount method with supporte network, should succeed
     service.linkExternalAccount('stackoverflow', "callback").then(function(data) {
@@ -151,6 +179,20 @@ describe('ExternalAccount Service', function() {
     $httpBackend.flush();
   });
 
+  it('should fail, with fatal error, in linking external account', function() {
+    var errorMessage = "endpoint not found";
+    profilePost.respond(404, {result:  { status: 404, content: errorMessage } });
+    // call unlinkExternalAccount method with supporte network, should succeed
+    service.linkExternalAccount('stackoverflow', "callback").then(function(data) {
+      sinon.assert.fail('should not be called');
+    }).catch(function(error) {
+      expect(error).to.be.defined;
+      expect(error.status).to.exist.to.equal('FATAL_ERROR');
+      expect(error.msg).to.exist.to.equal(errorMessage);
+    });
+    $httpBackend.flush();
+  });
+
   it('should unlink external account', function() {
     var errorMessage = "social profile exists";
     profilePost.respond(400, {result:  { status: 400, content: errorMessage } });

app/services/externalLinks.service.js

@@ -51,7 +51,7 @@
     }
 
     function removeLink(userHandle, key) {
-      return memberApi.one('members', userHandle).one('externalLinks', key).delete();
+      return memberApi.one('members', userHandle).one('externalLinks', key).remove();
     }
 
   }

app/services/externalLinks.service.spec.js

@@ -3,19 +3,31 @@ describe('ExternalWebLinks service', function() {
   var service;
   var mockExternalLinks = mockData.getMockExternalWebLinksData();
   var apiUrl;
+  var linksGet, linksPost, linksDelete;
 
 
   beforeEach(function() {
     bard.appModule('topcoder');
-    bard.inject(this, 'ExternalWebLinksService', '$httpBackend', 'CONSTANTS');
+    bard.inject(this, 'ExternalWebLinksService', 'JwtInterceptorService', '$httpBackend', 'CONSTANTS', '$q');
+    bard.mockService(JwtInterceptorService, {
+        getToken: $q.when('token'),
+        _default:    $q.when([])
+    });
 
     apiUrl  = CONSTANTS.API_URL;
     service = ExternalWebLinksService;
 
     // mock profile api
-    $httpBackend
-      .when('GET', apiUrl + '/members/test1/externalLinks/')
-      .respond(200, {result: {content: mockExternalLinks}});
+    linksGet = $httpBackend.when('GET', apiUrl + '/members/test1/externalLinks/');
+    linksGet.respond(200, {result: {content: mockExternalLinks}});
+
+    // mock profile api [POST]
+    linksPost = $httpBackend.when('POST', apiUrl + '/members/test1/externalLinks/');
+    linksPost.respond(200, {result: {content: mockExternalLinks[0]}});
+
+    // mock profile api [DELETE]
+    linksDelete = $httpBackend.when('DELETE', apiUrl + '/members/test1/externalLinks/testkey/');
+    linksDelete.respond(200, {result: {}});
   });
 
   afterEach(function() {
@@ -41,4 +53,24 @@ describe('ExternalWebLinks service', function() {
     $httpBackend.flush();
   });
 
+  it('should add external link', function() {
+    // call addLink method with valid params, should succeed
+    service.addLink('test1', "http://google.com").then(function(newLink) {
+      expect(newLink).to.be.exist;
+      expect(newLink.provider).to.exist.to.equal('weblink');
+      expect(newLink.data).to.exist;
+      expect(newLink.data.status).to.exist.to.equal('pending');
+    });
+    $httpBackend.flush();
+  });
+
+  it('should remove external link', function() {
+    // call removeLink method with valid params, should succeed
+    service.removeLink('test1', "testkey").then(function(newLink) {
+    }).catch(function(error) {
+      sinon.assert.fail('should not be called');
+    });
+    $httpBackend.flush();
+  });
+
 });