Merge branch 'dev' into feature/sup-2481-intergrate-web-links-api

* dev:
  Update
  Fix search bar, styling and placement  of user handle
  Move footer links to bottom of mobile nav, style white
  Fix formatting
  Fix import
  adjusted winner ribbon positioning
  Fix test
  Remove stopPropagation
  fixed srm calc
  fixed some design card display stuff
  Prevent the section from flickering
  quick fix
  more nav styling changes
  removing "only" from tests and fixing logout
  redirecting logout to home page, removing cookies etc
  SUP-2272, Profile--> Remove the mouse hover from profile image.
  SUP-2420, SiteMap--> Remove the 'Footer' section.
  Finished nav basics
  placeholder
  logo 'beta' tag css fix

Author: vikasrohit

README.md

@@ -58,7 +58,7 @@ The tests folder contains mock data (tests/test-helpers/mock-data.js). It also h
 Spec files live alongside the code they are testing. For example, in peer-review you have review-status.controller.js and review-status.spec.js in the same review-status folder. If you want to see an example of tests, use review-status.spec.js as an example of controller tests and services/challenge.service.spec.js as an example of service tests.
 
 ## UI-Router and States
-See sample.routes.js and peer-review.routes.js as examples.
+See any *.routes.js file as an example.
 
 ## Contributing
 
@@ -87,7 +87,7 @@ Jade Files
 ```
 
 SCSS Files
-  - Use SCSS syntax (nesting)
+  - Use SCSS syntax, but do not overly nest
   - Use variables and mixins as much as possible
   - Store new variables and mixins in the appropriate file in `assets/css/partials`
   - Since a class with the current state name is added to the ui-view (see the Creating New Views/Pages section), wrap your .scss file with this class, in order to write specific SCSS in its own file for that page.

app/account/account.routes.js

@@ -108,9 +108,13 @@
       },
       logout: {
         url: '/logout/',
-        controller: ['TcAuthService', function(TcAuthService) {
-          TcAuthService.logout();
-        }],
+        views: {
+          'header@': {},
+          'container@': {
+            controller: 'LogoutController'
+          },
+          'footer@': {}
+        },
         data: {
           authRequired: false
         }

app/account/logout/logout.controller.js

@@ -0,0 +1,19 @@
+(function() {
+  'use strict';
+
+  angular.module('tc.account').controller('LogoutController', LogoutController);
+
+  LogoutController.$inject = ['$log', 'TcAuthService', '$window', 'CONSTANTS'];
+
+  function LogoutController($log, TcAuthService, $window, CONSTANTS) {
+    $log = $log.getInstance('LogoutController');
+
+    TcAuthService.logout()
+    .then(function() {
+      $log.debug("successfully logged out.");
+      // redirect to home
+      $window.location.href = CONSTANTS.MAIN_URL;
+    });
+
+  }
+})();

app/account/logout/logout.controller.spec.js

@@ -0,0 +1,39 @@
+/* jshint -W117, -W030 */
+describe('Logout Controller', function() {
+  var controller;
+  var fakeWindow = {
+    location: {
+      href: ''
+    }
+  };
+
+
+  beforeEach(function() {
+    bard.appModule('topcoder');
+    bard.appModule('tc.account');
+    module('tc.account', function($provide) {
+      $provide.value('$window', fakeWindow);
+    });
+
+    bard.inject(this, '$controller', 'TcAuthService', '$window', '$q', 'CONSTANTS');
+
+    bard.mockService(TcAuthService, {
+      logout: $q.when({}),
+      _default: $q.when({})
+    });
+
+    controller = $controller('LogoutController');
+  });
+
+  bard.verifyNoOutstandingHttpRequests();
+
+  it('should be defined', function() {
+    expect(controller).to.be.defined;
+  });
+
+  it('should be successfully logged out', function() {
+    expect(TcAuthService.logout).to.have.been.calledOnce;
+    expect($window.location.href).to.equal(CONSTANTS.MAIN_URL);
+  });
+
+});

app/directives/header/header-menu-item.directive.jade

@@ -6,7 +6,7 @@ li.submenu-item(ng-if="item.sref && !item.srefParams")
 
 // external links
 li.submenu-item(ng-if="item.href && !item.srefParams")
-  a.menu-link(ng-click="$event.stopPropagation();" ng-href="{{item.href}}" ng-class="{ 'active': isActive() }" target="{{ item.target ? item.target : '_self'}}")
+  a.menu-link(ng-href="{{item.href}}" ng-class="{ 'active': isActive() }" target="{{ item.target ? item.target : '_self'}}")
     img.menu-icon(ng-src="{{item.icon}}")
     .menu-text {{item.text}}
 

app/directives/header/header-menu-item.directive.js

@@ -13,8 +13,9 @@
         var href = $scope.item.href;
 
         // I believe I have to hack this because of https://github.com/angular-ui/ui-router/issues/395, I tried ui-state
-        if ($scope.item.srefParams)
+        if ($scope.item.srefParams) {
           $scope.wtfhref = $state.href($scope.item.sref, $scope.item.srefParams);
+        }
 
         $scope.isActive = function() {
           if (window.location.pathname == href || $state.is(sref)) {
@@ -23,6 +24,7 @@
 
             return true;
           }
+
           return false;
         }
       }]

app/directives/profile-widget/profile-widget.jade

@@ -1,5 +1,5 @@
 .profile-widget-directive
-  a(ui-sref="profile.about({userHandle: profile.handle})")
+  .pic
     img.profile-circle(ng-if="profile.photoURL", ng-src="{{profile.photoURL}}")
     img.profile-circle(ng-if="!profile.photoURL", src="/images/ico-user-default.svg")
 

app/index.jade

@@ -37,6 +37,7 @@ html
     link(rel="stylesheet", href="assets/css/settings/edit-profile.css")
     link(rel="stylesheet", href="assets/css/settings/account-info.css")
     link(rel="stylesheet", href="assets/css/profile/subtrack.css")
+    link(rel="stylesheet", href="assets/css/profile/nav.css")
     link(rel="stylesheet", href="assets/css/profile/icons.css")
     link(rel="stylesheet", href="assets/css/profile/header.css")
     link(rel="stylesheet", href="assets/css/profile/badges.css")
@@ -166,6 +167,7 @@ html
     script(src="account/account.module.js")
     script(src="account/account.routes.js")
     script(src="account/login/login.controller.js")
+    script(src="account/logout/logout.controller.js")
     script(src="account/register/register.controller.js")
     script(src="account/reset-password/reset-password.controller.js")
     script(src="blocks/exception/exception.module.js")

app/layout/footer/footer.jade

@@ -2,20 +2,25 @@ footer.bottom-footer
   // Footer links
   nav.menu-item
     .menu-item-header.show-small OTHERS
+
     ul.submenu
-        li.submenu-item #[a.menu-link(ng-click="$event.stopPropagation();" href="/sitemap") SITEMAP]
-        li.submenu-item #[a.menu-link(ng-click="$event.stopPropagation();" href="/about") ABOUT US]
-        li.submenu-item #[a.menu-link(ng-click="$event.stopPropagation();" href="/contact-us") CONTACT US]
-        li.submenu-item #[a.menu-link(ng-click="$event.stopPropagation();" href="https://help.{{domain}}" target="_blank") HELP CENTER]
-        li.submenu-item #[a.menu-link(ng-click="$event.stopPropagation();" href="https://www.{{domain}}/community/how-it-works/privacy-policy/") PRIVACY POLICY]
-        li.submenu-item #[a.menu-link(ng-click="$event.stopPropagation();" href="https://www.{{domain}}/community/how-it-works/terms/") TERMS]
+      li.submenu-item #[a.menu-link(ng-href="https://www.{{domain}}/sitemap") SITE MAP]
+      li.submenu-item #[a.menu-link(ng-href="https://www.{{domain}}/about") ABOUT US]
+      li.submenu-item #[a.menu-link(ng-href="https://www.{{domain}}/contact-us") CONTACT US]
+      li.submenu-item #[a.menu-link(ng-href="https://help.{{domain}}" target="_blank") HELP CENTER]
+      li.submenu-item #[a.menu-link(ng-href="https://www.{{domain}}/community/how-it-works/privacy-policy/") PRIVACY POLICY]
+      li.submenu-item #[a.menu-link(ng-href="https://www.{{domain}}/community/how-it-works/terms/") TERMS]
 
     // Social links
   .social-links
     p Topcoder is also on
+
     a.fb-link(href="https://www.facebook.com/topcoder" target="fbwindow")
+
     a.twitter-link(href="http://www.twitter.com/topcoder" target="twwindow")
+
     a.linkedin-link(href="https://www.linkedin.com/company/topcoder" target="liwindow")
+
     a.google-link(href="https://plus.google.com/u/0/b/104268008777050019973/104268008777050019973/posts" target="gpwindow")
 
   p.copyright-notice © 2015 Topcoder. All Rights Reserved

app/layout/header/header.controller.js

@@ -11,7 +11,6 @@
     vm.constants = CONSTANTS;
     vm.domain = CONSTANTS.domain;
     vm.login = TcAuthService.login;
-    vm.logout = logout;
     vm.checkSubmit = checkSubmit;
     vm.searchTerm = '';
     vm.selectedGroup = selectedGroup;
@@ -65,13 +64,6 @@
       }
     }
 
-    function logout() {
-      TcAuthService.logout()
-      .then(function() {
-        $state.go('home');
-      });
-    }
-
     function selectedGroup() {
       return _.get(NavService, 'selectedTopLevelItem', null);
     }

app/layout/header/header.jade

@@ -1,6 +1,7 @@
 .header-wrapper(ng-class="{'autocomplete': main.searchTerm.length > 0}")
   header.top-header
     a.logo-link(href="/")
+      
     // Header content visible on small screens
     .show-small.mobile-heading
       span.tc-text-logo(ng-if="main.menuVisible") [ topcoder ]
@@ -11,8 +12,8 @@
 
       // User link (profile or join)
       a(ui-sref="profile.about({userHandle: vm.userHandle})", ng-switch="vm.isAuth" class="user-link" data-ng-if="!main.menuVisible")
-        //- img(ng-switch-when="true", class="user-avatar", ng-src="{{vm.profile.photoURL}}")
         img(ng-switch-when="true", ng-if="vm.profile.photoURL && vm.profile.photoURL.length", class="user-avatar", ng-src="{{vm.profile.photoURL}}")
+
         img(ng-switch-when="true", ng-if="!vm.profile.photoURL || !vm.profile.photoURL.length", class="user-avatar", ng-src="/images/ico-user-default.svg")
 
         span(ng-switch-when="false" class="tc-btn tc-btn-s") JOIN
@@ -29,7 +30,7 @@
           //     a(href="javascript:;" class="menu-link") {{suggestion}}
 
       li.menu-item.link-group.user-menu(ng-switch="vm.isAuth", ng-class="{'anonymous-menu': !vm.isAuth}")
-        // links for logged in user
+        // Links for logged in user
         div(ng-switch-when="true")
           .menu-item-header(
             ng-class="{'hide': vm.selectedGroup() == 'user'}"
@@ -49,22 +50,19 @@
             header-menu-item(ng-repeat="item in vm.userMenu" item="item")
 
             li.submenu-item
-              a.menu-link(ng-click="vm.logout(); main.menuVisible = vm.isAuth = false")
+              //- a.menu-link(ng-click="vm.logout(); main.menuVisible = vm.isAuth = false")
+              a.menu-link(ui-sref="logout")
                 img.menu-icon(ng-src="/images/nav/exit.svg")
+
                 .menu-text LOG OUT
 
-        // links for anonymous user
+        // Links for anonymous user
         .menu-item-header(ng-switch-when="false")
           a.tc-btn.tc-btn-s.btn-link(ui-sref="register") JOIN
 
           a.tc-btn.tc-btn-s.tc-btn-ghost.btn-link(ui-sref="login") LOG IN
 
-          //- a(ng-click="launchIntro();", ng-show="!!vm.introOptions") Intro
-
-      li.menu-item.link-group(
-        ng-repeat="(menu, items) in vm.menuLinks",
-        ng-class="{'selected': vm.selectedGroup() == menu}"
-      )
+      li.menu-item.link-group(ng-repeat="(menu, items) in vm.menuLinks", ng-class="{'selected': vm.selectedGroup() == menu}")
         .menu-item-header {{menu}}
 
         ul.submenu

app/profile/profile.controller.js

@@ -13,6 +13,7 @@
     // set profile to the object that was resolved
     vm.profile = profile;
     vm.userHandle = userHandle;
+    vm.handleColor = ProfileService.getUserHandleColor(profile);
     vm.showBadges = showBadges;
     vm.closeDialog = closeDialog;
     vm.scrollTo = scrollTo;

app/profile/profile.controller.spec.js

@@ -24,6 +24,9 @@ describe('Profile Controller', function() {
       getUserSkills: function() {
         return $q.when({result: {content: mockSkills}});
       },
+      getUserHandleColor: function() {
+        return 'something';
+      },
       getRanks: ProfileService.getRanks
     };
     // mock user api

app/profile/subtrack/nav.jade

@@ -1,3 +1,14 @@
+.nav-top
+  .user
+    .avatar
+      img(ng-src="{{vm.profile.photoURL}}")
+
+    .handle(style="color: {{vm.handleColor}}") {{vm.profile.handle}}
+
+  .exit(ng-click="vm.closeDialog()")
+    img(src="/images/x-mark-gray.svg")
+
+hr
 .categoryNav
   .track(
     ng-repeat="track in vm.profile.tracks",

app/profile/subtrack/subtrack.controller.js

@@ -227,7 +227,7 @@
         template: 'profile/subtrack/nav.html',
         controller: 'ProfileCtrl',
         controllerAs: 'vm',
-        className: 'ngdialog-theme-default',
+        className: 'ngdialog-nav-theme',
         resolve: {
           userHandle: function() {
             return vm.userHandle;

app/services/authToken.service.spec.js

@@ -58,6 +58,7 @@ describe('TcAuthToken Service', function() {
     it('should remove tokens from store & cookie"', function() {
       service.removeTokens();
       expect($cookies.remove).to.have.been.calledWith('tcjwt');
+      expect($cookies.remove).to.have.been.calledWith('tcsso');
       expect(store.remove).to.be.have.been.calledWith('appiriojwt');
     });
 

app/services/nav.service.js

@@ -8,10 +8,8 @@
   function NavService(CONSTANTS, $state, UserService, TcAuthService) {
 
     var service = {
-
       selectedTopLevelItem: null,
       getParent: getParent
-
     };
 
     service.menuLinks = {
@@ -47,6 +45,7 @@
     ];
 
     service.hrefs = {};
+
     service.menuLinks.compete.forEach(function(link) {
       link.parent = 'compete';
       service.hrefs[link.href] = link;
@@ -68,8 +67,9 @@
     });
 
     function getParent(ref) {
-      if (ref.indexOf('.') >= 0)
+      if (ref.indexOf('.') >= 0) {
         ref = ref.slice(0, ref.indexOf('.'));
+      }
 
       if (ref.match(/profile/)) {
         if (TcAuthService.isAuthenticated() && $state.params && $state.params.userHandle == UserService.getUserIdentity().handle) {
@@ -82,9 +82,6 @@
       }
     }
 
-
     return service;
-
   }
-
 })();

app/services/profile.service.js

@@ -273,7 +273,7 @@
         array.forEach(function(level) {
           level.problemsFailed = level.problemsFailed || level.failedChallenges || 0;
           level.problemsSubmitted = level.problemsSubmitted || level.challenges || 0;
-          level.problemsSuccessful = (level.problemsSubmitted - level.problemsFailed) || 0;
+          level.problemsSuccessful = (level.problemsSubmitted - level.problemsFailed - (level.problemsSysByTest || 0)) || 0;
           level.percentSuccessful = (level.problemsSuccessful / (level.problemsSubmitted || 1)) || 0;
           ans.total.problemsSuccessful += level.problemsSuccessful || (level.challenges - level.failedChallenges) || 0;
           ans.total.problemsFailed += level.problemsFailed || level.failedChallenges || 0;

app/settings/account-info/account-info.controller.js

@@ -16,6 +16,7 @@
 
     function activate() {
       vm.isSocialRegistrant = false;
+      vm.loading = true;
 
       vm.formProcessing = {
         accountInfoForm: false,
@@ -28,10 +29,12 @@
       UserService.getUserProfile({fields: 'credential'})
       .then(function(res) {
         vm.isSocialRegistrant = !res.credential.hasPassword;
+        vm.loading = false;
       })
       .catch(function(err) {
         $log.error("Error fetching user profile. Redirecting to edit profile.");
         $state.go('settings.profile');
+        vm.loading = false;
       });
 
       vm.countries = ISO3166.getAllCountryObjects();

app/settings/account-info/account-info.jade

@@ -11,7 +11,7 @@
       .form-label Email
       input.form-field.grey(name="email", value="{{vm.userData.email}}", disabled=true)
 
-      div(ng-hide="vm.isSocialRegistrant")
+      div(ng-if="!vm.isSocialRegistrant && !vm.loading")
         form(name="vm.newPasswordForm", role="form", ng-submit="vm.newPasswordForm.$valid && vm.submitNewPassword()", novalidate)
           .form-label Current password
 
@@ -45,7 +45,7 @@
             button.tc-btn.save(type="submit", tc-busy-button, tc-busy-when="vm.formProcessing.newPasswordForm", ng-disabled="vm.newPasswordForm.$invalid || vm.newPasswordForm.$pristine", ng-class="{'disabled': vm.newPasswordForm.$invalid || vm.newPasswordForm.$pristine}") Change Password
 
 
-      div(ng-show="vm.isSocialRegistrant")
+      div(ng-if="vm.isSocialRegistrant && !vm.loading")
         p You joined Topcoder by using an external account, so we don't have a password for you.
 
   form(name="vm.accountInfoForm", role="form", novalidate, autocomplete="off")