Skip to content

Fix: Append semicolon to item marco invocations #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2014
Merged

Fix: Append semicolon to item marco invocations #1

merged 1 commit into from
Dec 29, 2014

Conversation

tomprogrammer
Copy link
Owner

Following changes in rustc.

SimonSapin added a commit that referenced this pull request Dec 29, 2014
Fix: Append semicolon to item marco invocations
@SimonSapin SimonSapin merged commit b5d604f into tomprogrammer:master Dec 29, 2014
@SimonSapin
Copy link
Collaborator

Thanks! Just for my curiosity: what do you use this library in?

@tomprogrammer
Copy link
Owner Author

I'm using the ascii crate in my rethinkdb database client library. In the initial handshake a parameter is restricted to contain only Ascii. Currently my API enforces that with this Ascii type.

I'm not sure if I keep it or check the Ascii-compliance in my function and accepting &str. That would move the checking and error handling from the caller to my library.

Your RFC mainly was about mixed-encoding strings so my library applies to the corner case where full Ascii strings appear. For that use-case you split std::Ascii into an external crate I guess.

@tomprogrammer tomprogrammer deleted the rust-head branch December 29, 2014 14:20
@SimonSapin
Copy link
Collaborator

Alright. If you’re interested in maintaining the ascii crate I’m happy to give you push and publish access.

@tomprogrammer
Copy link
Owner Author

I can maintain the ascii-crate. I think it's very useful for strictly ascii compliant string handling.

@SimonSapin
Copy link
Collaborator

Alright! You are now a "collaborator" in this repository and an "owner" on crates.io.

@tomprogrammer
Copy link
Owner Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants