-
Notifications
You must be signed in to change notification settings - Fork 232
ci(tests) Verify runtime deps for CLI commands #967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request adds import statements for tmuxp.cli submodules in the tests workflow to verify runtime dependencies and ensure that development dependencies are not being imported during runtime. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tony - I've reviewed your changes - here's some feedback:
Overall Comments:
- It's great to see runtime dependencies being verified in CI.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #967 +/- ##
=======================================
Coverage 73.07% 73.07%
=======================================
Files 26 26
Lines 1857 1857
Branches 352 352
=======================================
Hits 1357 1357
Misses 396 396
Partials 104 104 ☔ View full report in Codecov by Sentry. |
Follow up to #965, cover import imports to test runtime behavior to make sure we're not importing dev deps.
Summary by Sourcery
Tests: