Skip to content

fix(load): passthru of tmux config_file #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2022

Conversation

zappolowski
Copy link
Contributor

f93179d erroneously renamed the argument for libtmux.server.Server which is still called config_file.

@CLAassistant
Copy link

CLAassistant commented Oct 31, 2022

CLA assistant check
All committers have signed the CLA.

f93179d erroneously renamed the
argument for `libtmux.server.Server` which is still called
`config_file`.
@tony tony force-pushed the fix/passing-tmux-config-file branch from 16cc3b4 to 02cfedd Compare October 31, 2022 12:03
tony
tony previously approved these changes Oct 31, 2022
Copy link
Member

@tony tony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. Will merge and release

@tony tony force-pushed the fix/passing-tmux-config-file branch from c88b134 to ab8e776 Compare October 31, 2022 12:08
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #843 (c88b134) into master (e9b0717) will not change coverage.
The diff coverage is n/a.

❗ Current head c88b134 differs from pull request most recent head ab8e776. Consider uploading reports for the commit ab8e776 to get more accurate results

@@           Coverage Diff           @@
##           master     #843   +/-   ##
=======================================
  Coverage   76.19%   76.19%           
=======================================
  Files          24       24           
  Lines        1613     1613           
  Branches      366      366           
=======================================
  Hits         1229     1229           
  Misses        275      275           
  Partials      109      109           
Impacted Files Coverage Δ
src/tmuxp/cli/load.py 69.66% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tony tony merged commit 9818f4f into tmux-python:master Oct 31, 2022
@tony
Copy link
Member

tony commented Oct 31, 2022

@zappolowski Well done, and nice job on the test too

Released v1.18.1 (GitHub, Tag, PyPI)

If you try it out, any better?

@zappolowski
Copy link
Contributor Author

Works for me now ... sorry for the wrong typing in the test. 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants