Skip to content

♻️ Massive refactor / organization #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 40 commits into from
Oct 30, 2022

Conversation

tony
Copy link
Member

@tony tony commented Oct 29, 2022

Rename config to workspace

Reference to "config" are now "workspace"

Organize files

  • cli/utils.py functions moved to workspace/finders.py

  • config.py split between:

    • workspace/finders.py
    • workspace/freezer.py
    • workspace/importers.py
    • workspace/validation.py
  • workspacebuilder.py split into:

    • workspace/builder.py

    • workspace/freezer.py

      config.inline moved to freezer

Tests

  • tests/fixtures/{workspacebuilder,workspacefreezer} -> tests/fixtures/workspace/{builder,freezer}
  • tests/test_import_{teamocil,tmuxinator}.py -> tests/workspace/test_import_{teamocil,tmuxinator}.py

@codecov
Copy link

codecov bot commented Oct 29, 2022

Codecov Report

Merging #840 (1b01058) into master (342eddc) will increase coverage by 0.13%.
The diff coverage is 84.30%.

@@            Coverage Diff             @@
##           master     #840      +/-   ##
==========================================
+ Coverage   76.05%   76.19%   +0.13%     
==========================================
  Files          20       24       +4     
  Lines        1604     1613       +9     
  Branches      366      366              
==========================================
+ Hits         1220     1229       +9     
  Misses        275      275              
  Partials      109      109              
Impacted Files Coverage Δ
src/tmuxp/cli/utils.py 55.65% <ø> (-10.02%) ⬇️
src/tmuxp/cli/edit.py 76.92% <33.33%> (ø)
src/tmuxp/cli/freeze.py 71.57% <71.42%> (+0.30%) ⬆️
src/tmuxp/cli/convert.py 82.50% <73.33%> (+0.44%) ⬆️
src/tmuxp/cli/load.py 69.66% <76.00%> (+0.29%) ⬆️
src/tmuxp/cli/import_config.py 81.81% <77.77%> (+0.27%) ⬆️
src/tmuxp/workspace/freezer.py 82.50% <82.50%> (ø)
src/tmuxp/workspace/importers.py 84.04% <84.04%> (ø)
src/tmuxp/workspace/loader.py 86.32% <86.32%> (ø)
src/tmuxp/workspace/finders.py 91.42% <91.42%> (ø)
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tony tony force-pushed the rename-config-file-to-workspace-file branch 8 times, most recently from fb0fb3b to 60cfc17 Compare October 30, 2022 14:19
@tony tony changed the title Rename "config file" to "workspace file" ♻️ Rename "config file" to "workspace file", refactoring Oct 30, 2022
@tony tony force-pushed the rename-config-file-to-workspace-file branch 2 times, most recently from 1098968 to 128e886 Compare October 30, 2022 14:41
@tony tony changed the title ♻️ Rename "config file" to "workspace file", refactoring ♻️ Massive refactor / organization Oct 30, 2022
@tony tony force-pushed the rename-config-file-to-workspace-file branch 4 times, most recently from 69c3a10 to 1b01058 Compare October 30, 2022 15:10
tony added 25 commits October 30, 2022 10:14
@tony tony force-pushed the rename-config-file-to-workspace-file branch from 1b01058 to 1c2fe29 Compare October 30, 2022 15:14
@tony tony merged commit 8666c07 into master Oct 30, 2022
@tony tony deleted the rename-config-file-to-workspace-file branch October 30, 2022 15:14
tony added a commit that referenced this pull request Oct 30, 2022
tony added a commit that referenced this pull request Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant