Remove kaptan -> ConfigReader
#828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tony
commented
Oct 1, 2022
•
tony
commented
- build(deps): Add types-PyYAML
- Remove kaptan
- Add ConfigReader: 200 lines of code, typed, w/ doctests
Codecov Report
@@ Coverage Diff @@
## master #828 +/- ##
=======================================
Coverage 75.00% 75.00%
=======================================
Files 18 18
Lines 1396 1396
Branches 326 326
=======================================
Hits 1047 1047
Misses 263 263
Partials 86 86 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tony
force-pushed
the
rm-kaptan
branch
8 times, most recently
from
ab22db0 to
00e7175
Compare
|
Similar PRs: vcs-python/vcspull#397, cihai/cihai#334 |
tony
added a commit
that referenced
this pull request
Oct 1, 2022
This was referenced Oct 2, 2022
Closed
tony
added a commit
that referenced
this pull request
Oct 8, 2022
This is needed after #828's transition from kaptan to ConfigReader.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.