Command options #752
Merged
Command options #752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #752 +/- ##
==========================================
+ Coverage 75.95% 76.05% +0.10%
==========================================
Files 7 7
Lines 1181 1186 +5
Branches 311 312 +1
==========================================
+ Hits 897 902 +5
Misses 197 197
Partials 87 87
Continue to review full report at Codecov.
|
tony
force-pushed
the
command-options
branch
2 times, most recently
from
da01974 to
56b40a7
Compare
Merged
tony
force-pushed
the
command-options
branch
2 times, most recently
from
5fdafe6 to
8fe461c
Compare
tony
force-pushed
the
command-options
branch
3 times, most recently
from
44007d8 to
6fe6c9e
Compare
Commands are now a different format:
Before:
"echo hello"
After:
{
"cmd": "echo hello"
}
This is purely internal. Normal usage should be the same since the
configuration emits the equivalent result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make way for per-command options such as
enter: false(#52), commands are now a different format:Before,
str:"echo hello"After,
dict:{ "cmd": "echo hello" }This is purely internal. Normal usage should be the same since the
configuration emits the equivalent result.