Skip to content

Black: format w/ string normalization #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2022
Merged

Conversation

tony
Copy link
Member

@tony tony commented Feb 22, 2022

libtmux counterpart: tmux-python/libtmux#354

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #738 (2b069bf) into master (4ad9d10) will not change coverage.
The diff coverage is 75.68%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #738   +/-   ##
=======================================
  Coverage   75.96%   75.96%           
=======================================
  Files           7        7           
  Lines        1190     1190           
  Branches      311      311           
=======================================
  Hits          904      904           
  Misses        199      199           
  Partials       87       87           
Impacted Files Coverage Δ
tmuxp/exc.py 95.45% <ø> (ø)
tmuxp/shell.py 40.71% <15.78%> (ø)
tmuxp/cli.py 73.51% <72.00%> (ø)
tmuxp/workspacebuilder.py 85.26% <77.94%> (ø)
tmuxp/config.py 85.77% <82.65%> (ø)
tmuxp/util.py 84.41% <86.66%> (ø)
tmuxp/plugin.py 95.34% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ad9d10...2b069bf. Read the comment docs.

@tony tony force-pushed the black-string-normalization branch from 8cec181 to 2418bb6 Compare February 22, 2022 13:01
@tony tony force-pushed the black-string-normalization branch from 2418bb6 to 2b069bf Compare February 26, 2022 15:56
@tony tony merged commit da2192a into master Feb 26, 2022
@tony tony deleted the black-string-normalization branch February 26, 2022 16:00
tony added a commit to tmux-python/libtmux that referenced this pull request Feb 26, 2022
…ed (#354)

This is a one-time diff

Personally, I don't think double quotes are better - it's just easier to
use black formatter without having to specify a config setting.

Controversy can be seen here:
psf/black#118, psf/black#1794

tmuxp's counterpart: tmux-python/tmuxp#738
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant