-
Notifications
You must be signed in to change notification settings - Fork 232
Decouple shell helpers, shell tweaks #641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #641 +/- ##
==========================================
- Coverage 77.65% 73.53% -4.12%
==========================================
Files 6 7 +1
Lines 962 1043 +81
Branches 267 268 +1
==========================================
+ Hits 747 767 +20
- Misses 149 202 +53
- Partials 66 74 +8
Continue to review full report at Codecov.
|
83dbf86
to
63bc260
Compare
e719f71
to
477ec68
Compare
b802c22
to
7744d7c
Compare
f784998
to
b213ca4
Compare
b213ca4
to
4f96c8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #640
Related: #638, #636
Move shell code to
shell.py
Move identification of tmux objects to
util.py
tmuxp shell
will automatically detect the "best" interactive console (e.g. ptipython, ptpython, ipython, bpython, etc.). It will automatically detect 3.7 +PYTHONBREAKPOINT
, and allow overriding any implicit behavior by passing--shell
tmuxp shell will automatically create server + session if doesn't exist. It can reinvoke itself inside a tmux server it launches, or launch in the background by passing
-d
(detached)