Skip to content

Decouple shell helpers, shell tweaks #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 7, 2020
Merged

Decouple shell helpers, shell tweaks #641

merged 11 commits into from
Nov 7, 2020

Conversation

tony
Copy link
Member

@tony tony commented Nov 7, 2020

Fixes #640

Related: #638, #636

Move shell code to shell.py

Move identification of tmux objects to util.py

tmuxp shell will automatically detect the "best" interactive console (e.g. ptipython, ptpython, ipython, bpython, etc.). It will automatically detect 3.7 + PYTHONBREAKPOINT, and allow overriding any implicit behavior by passing --shell

tmuxp shell will automatically create server + session if doesn't exist. It can reinvoke itself inside a tmux server it launches, or launch in the background by passing -d (detached)

@codecov
Copy link

codecov bot commented Nov 7, 2020

Codecov Report

Merging #641 (8226759) into master (be35db2) will decrease coverage by 4.11%.
The diff coverage is 54.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #641      +/-   ##
==========================================
- Coverage   77.65%   73.53%   -4.12%     
==========================================
  Files           6        7       +1     
  Lines         962     1043      +81     
  Branches      267      268       +1     
==========================================
+ Hits          747      767      +20     
- Misses        149      202      +53     
- Partials       66       74       +8     
Impacted Files Coverage Δ
tmuxp/shell.py 41.54% <41.54%> (ø)
tmuxp/cli.py 69.65% <80.95%> (-0.62%) ⬇️
tmuxp/util.py 89.18% <85.36%> (-4.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be35db2...8226759. Read the comment docs.

@tony tony force-pushed the shell-reorganization branch from 83dbf86 to 63bc260 Compare November 7, 2020 10:58
@tony tony force-pushed the shell-reorganization branch from e719f71 to 477ec68 Compare November 7, 2020 11:47
@tony tony force-pushed the shell-reorganization branch 4 times, most recently from b802c22 to 7744d7c Compare November 7, 2020 14:01
@tony tony force-pushed the shell-reorganization branch 2 times, most recently from f784998 to b213ca4 Compare November 7, 2020 14:52
@tony tony force-pushed the shell-reorganization branch from b213ca4 to 4f96c8f Compare November 7, 2020 14:55
@tony tony merged commit 19b507e into master Nov 7, 2020
@tony tony deleted the shell-reorganization branch November 7, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tmuxp shell: Tweaks for 1.6.1
1 participant