-
Notifications
You must be signed in to change notification settings - Fork 232
Allow overwrite on freeze #618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #618 +/- ##
==========================================
+ Coverage 77.08% 77.10% +0.02%
==========================================
Files 6 6
Lines 829 830 +1
Branches 238 238
==========================================
+ Hits 639 640 +1
Misses 131 131
Partials 59 59
Continue to review full report at Codecov.
|
@betoSolares Thank you! Can you add a test for this possibly? |
Yeah, no problem. |
@betoSolares Hi there, sorry about this! Can I get another rebase? I just merged #623 which moves us to a poetry packaging setup and will runs the PR through GitHub actions. |
8825cd1
to
551ed77
Compare
Rebase done. |
Are you sure its rebased against current master? (tests would be running, it seems its not the latest) |
@tony I think so. I run:
then I did |
Looks fine now! Thank you! I will check this out soon! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
As mentioned in #64 and #537 it would be nice to have an option to overwrite the config file.
This will give the
freeze
command a new option to overwrite the configuration file.