Load config appending windows in current active session

[emanuelhfarias]

I see some people requesting this feature (me included) #289 #373 and some even tried to add this functionality #374 #407 but those ideas never went from draft.

I decided to implement this feature maintaining the compatibility with features we already have (open attached and detached). The motivation to this feature is because I feel more productive seen everything I have opened as visible windows. I tried to use several sessions and switch-sessions using tmux shortcut C-b s but I didn't get use to it (maybe I will try again in the future).

Summarizing what this PR adds:
When you try to load a config file within a current open tmux session it will ask you if you want to:

1. create a new session and attach?
2. create a new session and detach?
3. load config appending windows in the current active session?

To maintain the compatibility I didn't change the question, I just added another option to the user.

Already inside TMUX, switch to session? yes/no
Or (a)ppend windows in the current active session?
[y/n/a]:

If you anwser:
Yes it will attach
No will detach
Append will append windows in the same session

I also added the ability to force append using the CLI:
$ tmuxp load -a config

I hope to see this feature in tmuxp. Who else's want? 👆

[MagicDuck]

Me needs this as well 😍

[Wesmania]

+1, it's really convenient to setup just a single window with a few panes without creating a new session.

[Wesmania]

It seems that the active session is not detected correctly. Something like this should work better:

    def find_current_attached_session(self):
        sid = self.server.cmd("display", "-pt", os.environ['TMUX_PANE'], "#{session_id}")
        return self.server.get_by_id(sid.stdout[0])

[nickwynja]

I also think it's helpful to switch to an existing session instead of throwing an error, like this: nickwynja@8db9026

[tony]

@emanuelhfarias Hi there, sorry about this! Can I get another rebase?

I just merged #623 which moves us to a poetry packaging setup and will runs the PR through GitHub actions.

[wantguns]

Is this PR still active ? I would love to get this feature merged.
Awesome work with tmuxp btw

[tony]

@emanuelhfarias Can you rebase this?

[emanuelhfarias]

@emanuelhfarias Can you rebase this?

yes

[emanuelhfarias]

I'm trying to rebase but the code has change a lot. It is difficult to solve all the conflicts and keep everything working. This PR is one year and a half old.
I'm not even using tmuxp anymore. If anyone wants this, the method that change the most is def load_workspace() from cli.py.

[tony]

@emanuelhfarias Sure, someone can fork this PR and try to rebase it. (Or do it manually on top of master, without git's conflict tool) Thank you once again for this PR, and sorry for the delay! On 12/27/2020 2:40:38 PM, Emanuel H. Farias <[email protected]> wrote: I'm trying to rebase but the code has change a lot. It is difficult to solve all the conflicts and keep everything working. This PR is one year and a half old. I'm not even using tmuxp anymore. If anyone wants this, the method that change the most is def load_workspace() from cli.py. — You are receiving this because you commented. Reply to this email directly, view it on GitHub [#501 (comment)], or unsubscribe [https://github.com/notifications/unsubscribe-auth/AAAGNYCQL7GX5ZJAZAJEV63SW6LULANCNFSM4IAN2U6Q].

[will-ockmore]

Hey everyone, I've opened a new PR #656 with these changes, unfortunately I wasn't able to rebase your work without difficult to resolve conflicts @emanuelhfarias - I've credited you in the PR itself as it's almost entirely your work, I just added a bugfix and some cleanup. Thanks for opening this PR! I've been looking for this functionality. Hoping we can get it merged in 🤞

[will-ockmore]

This work has been merged in #656 🙌