Skip to content

Use XDG base directory specification for config files #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 16, 2018

Conversation

anddam
Copy link
Contributor

@anddam anddam commented Jul 5, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 5, 2018

Codecov Report

Merging #404 into master will increase coverage by 0.16%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #404      +/-   ##
==========================================
+ Coverage   74.39%   74.55%   +0.16%     
==========================================
  Files           5        5              
  Lines         785      794       +9     
  Branches      228      231       +3     
==========================================
+ Hits          584      592       +8     
+ Misses        148      147       -1     
- Partials       53       55       +2
Impacted Files Coverage Δ
tmuxp/cli.py 56.23% <83.33%> (+0.6%) ⬆️
tmuxp/workspacebuilder.py 89.09% <0%> (+0.6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e048abf...ba22a66. Read the comment docs.

@tony
Copy link
Member

tony commented Jul 5, 2018

@anddam Looks good to me. I'll take a look this weekend. :)

@anddam
Copy link
Contributor Author

anddam commented Jul 6, 2018

Thanks, I had a big fight with git and ended up squashing and re-creating the topic branches from my previous pull requests, that I have now deleted. The feature changes should be properly separated now.

@mcchrish
Copy link

mcchrish commented Oct 15, 2018

@anddam @tony this is very neat change. Just a small nudge. Hope this feature can be merged and released soon.

@tony
Copy link
Member

tony commented Oct 15, 2018

Mmm, and I'm late on my promise to look at it too...

@anddam Can we get a rebase? (to run it through CI again)

@anddam anddam force-pushed the feature-use-xdg-config-directory branch from 0c13d4e to ceec5f8 Compare October 15, 2018 14:27
@rfoliva rfoliva merged commit 6194c0d into tmux-python:master Oct 16, 2018
@rfoliva
Copy link
Contributor

rfoliva commented Oct 16, 2018

Thanks @anddam for the contribution.

I have just merged it.

@anddam anddam deleted the feature-use-xdg-config-directory branch October 16, 2018 13:51
tony added a commit that referenced this pull request Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants