Skip to content

Add start-directory argument when creating new tmux session #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

anddam
Copy link
Contributor

@anddam anddam commented Jul 5, 2018

Fix enconding name as well.

@anddam
Copy link
Contributor Author

anddam commented Oct 16, 2018

This breaks with TMUX_VERSION <= 1.8, should I catch that in code or is it safe (where "safe" actually means easier) to just require a minimum tmux version of 1.9?

It is a handy little feature since it allows me to name my layout in config and have that reflected in the inited tmux session.

@anddam anddam force-pushed the feature-use-tmux-session-start-option branch from 56088c2 to bf8e3f8 Compare October 16, 2018 10:20
@codecov-io
Copy link

Codecov Report

Merging #403 into master will decrease coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
- Coverage   74.93%   74.58%   -0.36%     
==========================================
  Files           5        5              
  Lines         794      779      -15     
  Branches      231      227       -4     
==========================================
- Hits          595      581      -14     
+ Misses        146      141       -5     
- Partials       53       57       +4
Impacted Files Coverage Δ
tmuxp/workspacebuilder.py 86.66% <ø> (-4.25%) ⬇️
tmuxp/exc.py 95.23% <0%> (ø) ⬆️
tmuxp/config.py 85.36% <0%> (ø) ⬆️
tmuxp/util.py 90.9% <0%> (ø) ⬆️
tmuxp/cli.py 56.68% <0%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6194c0d...bf8e3f8. Read the comment docs.

@tony
Copy link
Member

tony commented Aug 16, 2020

@anddam Can you rebase this?

I just merged #623 which moves us to a poetry packaging setup and will runs the PR through GitHub actions.

@tony
Copy link
Member

tony commented Aug 16, 2020

@anddam Is this the same as #197?

@anddam
Copy link
Contributor Author

anddam commented Aug 17, 2020

@anddam Is this the same as #197?

No, #197 was better. I am closing this.

@anddam anddam closed this Aug 17, 2020
@tony
Copy link
Member

tony commented Aug 17, 2020

Thank you @anddam!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants