Skip to content

Fixes 'focus' problem. #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

anselmos
Copy link

@anselmos anselmos commented Mar 27, 2018

What this PR fixes
This PR should fix or at least hack the problem with focus attribute not working properly.

Related Issues

This PR should fix problems found at #326 and #371

Versions used for this PR

Using latest version of tmuxp : 1.4.0
tmux version : 2.6
latest release of libtmux: 0.8.0

What the PR changes

This PR comments out usage of set_layout_hook that broke focus attribute.

Comments out set_layout_hook for tmux 2.6 version that is only for outside of tmux
@anselmos
Copy link
Author

@tony PTAL - I hope I did not broke anything with this PR - especially the #309 and #312 .

@codecov-io
Copy link

codecov-io commented Mar 27, 2018

Codecov Report

Merging #371 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #371   +/-   ##
=======================================
  Coverage   75.06%   75.06%           
=======================================
  Files           5        5           
  Lines         794      794           
  Branches      231      231           
=======================================
  Hits          596      596           
  Misses        146      146           
  Partials       52       52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4aa2e2...cf76035. Read the comment docs.

@tony
Copy link
Member

tony commented Mar 28, 2018

So, it's on the right track. We know that this was introduced in #312 (fix for #309). Unfortunately it wasn't backed by a test, which is why this passed in Travis - it would break all tmux 2.6 releases (and probably later).

The issue with the PR in its current form is we don't want to reintroduce #309's issue.

The good news is we know there's something with the hook fix that causes this focus issue.

We need a way to retain the #312 fix (or something equivalent that fixes #309) and fix focus too.

@anselmos
Copy link
Author

anselmos commented Nov 9, 2019

Closing as #500 has fixed this problem.

@anselmos anselmos closed this Nov 9, 2019
@anselmos anselmos deleted the fixing_focus branch November 9, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants