Skip to content

Update Vi copy and paste key bindings for tmux 2.4 #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update Vi copy and paste key bindings for tmux 2.4 #242

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 26, 2017

No description provided.

@codecov-io
Copy link

codecov-io commented Apr 26, 2017

Codecov Report

Merging #242 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #242   +/-   ##
=======================================
  Coverage   83.68%   83.68%           
=======================================
  Files           5        5           
  Lines         754      754           
=======================================
  Hits          631      631           
  Misses        123      123

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eabe5e...9e42729. Read the comment docs.

@tony
Copy link
Member

tony commented Apr 26, 2017

@ghost
Copy link
Author

ghost commented Apr 26, 2017

I like it, but I'm afraid that it may be less readable for beginners. On the other hand, we can assume that someone who uses tmux is a more advanced user.

@tony
Copy link
Member

tony commented Apr 26, 2017

My concern is that readers could copy and paste that configuration in and, as you said, since they're beginners, if they didn't comment it out manually, it could break.

Any idea how'd you like to approach? Perhaps mentioning to check $ tmux -V and splitting up the copy-paste thing into separate codeblocks depending on the version?

@ghost
Copy link
Author

ghost commented Apr 26, 2017

I see your point! Maybe splitting the code would be the best solution.

@tony
Copy link
Member

tony commented Apr 26, 2017

Go ahead and give it a shot.

@tony tony mentioned this pull request Oct 7, 2017
@tony
Copy link
Member

tony commented Mar 4, 2018

Sorry for the late response, I am having issues keeping up with the project. I'm seeking maintainers @ #290. If you (or someone you know) may be interested in helping maintain libtmux or tmuxp, feel free to contact me by email or in the #290 issue.

In the mean time, if you're still interested in this PR, can you rebase it via git pull --rebase origin master and git push --force?

@tony
Copy link
Member

tony commented Aug 16, 2020

@fszymanski Can you rebase this?

I just merged #623 which moves us to a poetry packaging setup and will runs the PR through GitHub actions.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tony
Copy link
Member

tony commented Jan 29, 2022

@fszymanski

Sorry for any inconvenience caused on my part. I let the PR go on too long. That is my fault.

Can you please remake this PR with the newest master?

Since you made this change the doc is now in markdown: https://github.com/tmux-python/tmuxp/blob/b9f35df/docs/about_tmux.md

I will close this for now but please feel free to make a new PR off master.

@tony tony closed this Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants