-
Notifications
You must be signed in to change notification settings - Fork 232
Update Vi copy and paste key bindings for tmux 2.4 #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
=======================================
Coverage 83.68% 83.68%
=======================================
Files 5 5
Lines 754 754
=======================================
Hits 631 631
Misses 123 123 Continue to review full report at Codecov.
|
What do you think of this: https://github.com/tony/tmux-config/blob/4e6c638/.tmux.conf#L92 |
I like it, but I'm afraid that it may be less readable for beginners. On the other hand, we can assume that someone who uses |
My concern is that readers could copy and paste that configuration in and, as you said, since they're beginners, if they didn't comment it out manually, it could break. Any idea how'd you like to approach? Perhaps mentioning to check |
I see your point! Maybe splitting the code would be the best solution. |
Go ahead and give it a shot. |
Sorry for the late response, I am having issues keeping up with the project. I'm seeking maintainers @ #290. If you (or someone you know) may be interested in helping maintain libtmux or tmuxp, feel free to contact me by email or in the #290 issue. In the mean time, if you're still interested in this PR, can you rebase it via |
|
@fszymanski Sorry for any inconvenience caused on my part. I let the PR go on too long. That is my fault. Can you please remake this PR with the newest master? Since you made this change the doc is now in markdown: https://github.com/tmux-python/tmuxp/blob/b9f35df/docs/about_tmux.md I will close this for now but please feel free to make a new PR off master. |
No description provided.