Skip to content

Add support for renaming session during load #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

kenwarner
Copy link

Addresses #206

@codecov-io
Copy link

Codecov Report

Merging #208 into master will increase coverage by -0.07%.

@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
- Coverage   83.82%   83.75%   -0.07%     
==========================================
  Files           5        5              
  Lines         742      745       +3     
==========================================
+ Hits          622      624       +2     
- Misses        120      121       +1
Impacted Files Coverage Δ
tmuxp/cli.py 65.05% <75%> (+0.01%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ab1f17...6c0cfc3. Read the comment docs.

@tony
Copy link
Member

tony commented Jun 21, 2017

@kenwarner Sorry for the delay,

Can you update and add a test case for this?

@tony tony mentioned this pull request Oct 7, 2017
@tony
Copy link
Member

tony commented Mar 4, 2018

Sorry for the late response, I am having issues keeping up with the project. I'm seeking maintainers @ #290. If you (or someone you know) may be interested in helping maintain libtmux or tmuxp, feel free to contact me by email or in the #290 issue.

In the mean time, if you're still interested in this PR, can you rebase it via git pull --rebase origin master?

@tony
Copy link
Member

tony commented Aug 16, 2020

@kenwarner Can you rebase this?

I just merged #623 which moves us to a poetry packaging setup and will runs the PR through GitHub actions.

@joseph-flinn joseph-flinn mentioned this pull request Aug 30, 2020
@tony
Copy link
Member

tony commented Aug 30, 2020

@kenwarner : is it possible you could give this a rebase? Sorry for getting to this late!

There is another PR by @joseph-flinn at #623 and I received an email from him.

@kenwarner
Copy link
Author

@tony sorry I just noticed this. I'll do the rebase shortly 👍

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tony
Copy link
Member

tony commented Jan 29, 2022

@kenwarner Do you want to continue with this PR? There is a conflict that needs to be solved via rebase

@tony
Copy link
Member

tony commented Feb 22, 2022

@kenwarner I am closing this now, but if you have interest in making it again please feel free to make one

It's my fault for not getting to the PR in a timely fashion, my bad on that.

If you do make a PR in the future please email me so I can look at it first thing

@tony tony closed this Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants