WIP. Empty window titles cause errors. #183 #189

BlitzKraft · 2016-11-10T13:10:12Z

Added functions for testing empty titles and a config
window_title_empty.yaml.

Added functions for testing empty titles and a config window_title_empty.yaml.

BlitzKraft · 2016-11-10T13:12:23Z

I need some pointers on getting the window titles right. When the title is not set or empty, the title gets set to the shell (bash, in my case).

tony · 2016-12-22T20:49:16Z

can you rebase this against the latest codebase?

BlitzKraft · 2016-12-22T21:02:43Z

Will do.

tony · 2018-03-04T20:53:26Z

Sorry for the late response, I am having issues keeping up with the project. I'm seeking maintainers @ #290. If you (or someone you know) may be interested in helping maintain libtmux or tmuxp, feel free to contact me by email or in the #290 issue.

In the mean time, if you're still interested in this PR, can you rebase it via git pull --rebase origin master and git push --force?

BlitzKraft · 2018-03-04T21:02:24Z

I'll rebase and see how it goes. I am interested in maintaining this project.

tony · 2018-03-04T22:35:52Z

If you're not able to rebase immediately, that's also fine, but if you do, ping me here. GitHub has an issue notifying me when force pushes happen (even when I'm watching).

If you can pitch in time to help maintain, can you drop a message in #290? In addition to registering your interest and how much time you can commit, it would be encouraging for more people to come forward, too. My hope is to always have at least one person on duty and a quick turnaround time on issues/PRs. I'm wondering if we need a couple people? Other than that, ATM I'm working on some issues to streamline contributions/issues/debugging.

I'm also weighing creating an organization for tmuxp/libtmux.

tony · 2018-03-04T22:36:44Z

Also, I didn't mention this, but after a git pull --rebase origin master, you will have to git push --force the branch. That's OK in this case, since it's your branch on your fork, and a pull request.

tony · 2020-07-09T17:18:26Z

Can you give this a rebase? @BlitzKraft

tony · 2020-08-16T16:30:30Z

@BlitzKraft Can you rebase? (giving you a ping)

If I don't get a response, I may close the PR (I think?) - but you can still create a new PR if you / someone else regains interest in it

BlitzKraft · 2020-08-16T16:41:44Z

Got it, I will rebase.

tony · 2020-08-16T16:42:44Z

Nice! That was quick. Welcome back @BlitzKraft

Added functions for testing empty titles and a config window_title_empty.yaml.

BlitzKraft · 2020-08-16T20:36:06Z

Seems I might have messed up. Not sure how to fix. What do you suggest?

tony · 2020-08-16T20:38:30Z

git reflog can help you

Since you probably have the old ref : https://stackoverflow.com/a/10099285/1396928

You'd git reset --hard <ref>

@BlitzKraft Would that help?

codecov · 2020-08-16T20:40:11Z

Codecov Report

Merging #189 into master will decrease coverage by 3.18%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
- Coverage   77.08%   73.89%   -3.19%     
==========================================
  Files           6        6              
  Lines         829      835       +6     
  Branches      238      241       +3     
==========================================
- Hits          639      617      -22     
- Misses        131      160      +29     
+ Partials       59       58       -1

Impacted Files	Coverage Δ
tmuxp/workspacebuilder.py	`83.43% <0.00%> (-5.06%)`	⬇️
tmuxp/config.py	`87.09% <100.00%> (+0.91%)`	⬆️
tmuxp/cli.py	`60.00% <0.00%> (-6.00%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdb2154...7316fdd. Read the comment docs.

BlitzKraft · 2020-08-16T20:40:52Z

I think I got it. Did not reflog. I think this commit should be squashed. And I need to run the tests locally first. I keep forgetting to do that.

tony · 2020-08-16T20:42:01Z

@BlitzKraft Nice

Are the new gh action tests helpful? They should detect if other functionality was affected / any tests added

BlitzKraft · 2020-08-16T20:49:18Z

I think they are helpful. I haven't used them very much. I need to get a hang of that.

BlitzKraft · 2020-08-16T21:08:53Z

make test encounters this: https://dpaste.org/zGVC

Should I just ignore that?

tony · 2020-08-17T09:45:21Z

@BlitzKraft poetry install -E "docs test coverage lint format"

Does doing this and rerunning change anything?

pip show pytest

Are you using poetry for this? e.g. poetry shell, poetry run py.test ?

tony · 2020-08-17T09:45:48Z

(it's not a requirement but gives more piece of mind you have only the locked packages installed)

BlitzKraft · 2020-08-17T13:15:11Z

I was missing some dependencies. Installing them using poetry, like you mentioned, I was able to run all the tests.

There is still one failing test. test_window_title - is there a separate test for empty titles?

tony

@BlitzKraft see if this helps with the test

tony · 2020-08-17T13:36:30Z

tmuxp/workspacebuilder.py

+        if w.name == '':
+            empty_window_title = True


Suggested change

if w.name == '':

empty_window_title = True

empty_window_title = w.name == ''

Assures the variable is always declared

Should fix https://github.com/tmux-python/tmuxp/pull/189/checks?check_run_id=991200510#step:15:372:

wconf['panes'].append(pconf) > if empty_window_title: E UnboundLocalError: local variable 'empty_window_title' referenced before assignment tmuxp/workspacebuilder.py:416: UnboundLocalError

That resolves the unbound variable. I am adding that change.

tony · 2020-08-17T13:45:21Z

tmuxp/config.py

@@ -209,7 +209,10 @@ def expand(sconf, cwd=None, parent=None):
    if 'session_name' in sconf:
        sconf['session_name'] = expandshell(sconf['session_name'])
    if 'window_name' in sconf:
-        sconf['window_name'] = expandshell(sconf['window_name'])
+        if not (sconf['window_name'] is None):


Suggested change

if not (sconf['window_name'] is None):

if sconf['window_name'] is not None:

This does not change the outcome of the test_window_title. As expected. The if statements - before and after the suggested changes - are equivalent. Were you expecting something different?

Found something. window_name is being set to tmux. Hence the failing assertion. Now, need to dig where this is happening.

tony · 2021-01-09T14:16:57Z

@BlitzKraft Have you looked at the tests yet? (It says the tests failed)

CLAassistant · 2022-01-11T03:28:06Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ BK Bolisetty
❌ BlitzKraft

BK Bolisetty seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

tony · 2022-01-29T12:34:31Z

@BlitzKraft

If you want to continue with this contribution, please make a new pull request based off the newest master.

I am going to close this pull request for now as a significant amount of time has passed.

Also I am at fault for letting the wait go too long in between. Sorry about that.

Window titles

This may behave differently depending on tmux's config itself, via automatic-rename (e.g. setw -g automatic-rename)

A future PR would need to account for that

WIP. Empty window titles cause errors. tmux-python#183

c0e3262

Added functions for testing empty titles and a config window_title_empty.yaml.

tony mentioned this pull request Oct 7, 2017

Fix travis #304

Closed

BK Bolisetty and others added 2 commits August 16, 2020 16:29

WIP. Empty window titles cause errors. tmux-python#183

97cdae5

Added functions for testing empty titles and a config window_title_empty.yaml.

Merge branch 'empty' of github.com:BlitzKraft/tmuxp into empty

7fbf96e

Fix equality to None. flake8

7316fdd

tony self-requested a review August 17, 2020 13:37

tony requested changes Aug 17, 2020

View reviewed changes

tony closed this Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP. Empty window titles cause errors. #183 #189

WIP. Empty window titles cause errors. #183 #189

BlitzKraft commented Nov 10, 2016

BlitzKraft commented Nov 10, 2016

tony commented Dec 22, 2016

BlitzKraft commented Dec 22, 2016

tony commented Mar 4, 2018 •

edited

Loading

BlitzKraft commented Mar 4, 2018

tony commented Mar 4, 2018 •

edited

Loading

tony commented Mar 4, 2018 •

edited

Loading

tony commented Jul 9, 2020

tony commented Aug 16, 2020

BlitzKraft commented Aug 16, 2020

tony commented Aug 16, 2020

BlitzKraft commented Aug 16, 2020

tony commented Aug 16, 2020

codecov bot commented Aug 16, 2020

BlitzKraft commented Aug 16, 2020

tony commented Aug 16, 2020

BlitzKraft commented Aug 16, 2020

BlitzKraft commented Aug 16, 2020

tony commented Aug 17, 2020

tony commented Aug 17, 2020

BlitzKraft commented Aug 17, 2020

tony left a comment

tony Aug 17, 2020

BlitzKraft Aug 17, 2020

tony Aug 17, 2020

BlitzKraft Aug 17, 2020

BlitzKraft Aug 17, 2020

tony commented Jan 9, 2021 •

edited

Loading

CLAassistant commented Jan 11, 2022

tony commented Jan 29, 2022

	if w.name == '':
	empty_window_title = True
	empty_window_title = w.name == ''

	if not (sconf['window_name'] is None):
	if sconf['window_name'] is not None:

WIP. Empty window titles cause errors. #183 #189

WIP. Empty window titles cause errors. #183 #189

Conversation

BlitzKraft commented Nov 10, 2016

BlitzKraft commented Nov 10, 2016

tony commented Dec 22, 2016

BlitzKraft commented Dec 22, 2016

tony commented Mar 4, 2018 • edited Loading

BlitzKraft commented Mar 4, 2018

tony commented Mar 4, 2018 • edited Loading

tony commented Mar 4, 2018 • edited Loading

tony commented Jul 9, 2020

tony commented Aug 16, 2020

BlitzKraft commented Aug 16, 2020

tony commented Aug 16, 2020

BlitzKraft commented Aug 16, 2020

tony commented Aug 16, 2020

codecov bot commented Aug 16, 2020

Codecov Report

BlitzKraft commented Aug 16, 2020

tony commented Aug 16, 2020

BlitzKraft commented Aug 16, 2020

BlitzKraft commented Aug 16, 2020

tony commented Aug 17, 2020

tony commented Aug 17, 2020

BlitzKraft commented Aug 17, 2020

tony left a comment

Choose a reason for hiding this comment

tony Aug 17, 2020

Choose a reason for hiding this comment

BlitzKraft Aug 17, 2020

Choose a reason for hiding this comment

tony Aug 17, 2020

Choose a reason for hiding this comment

BlitzKraft Aug 17, 2020

Choose a reason for hiding this comment

BlitzKraft Aug 17, 2020

Choose a reason for hiding this comment

tony commented Jan 9, 2021 • edited Loading

CLAassistant commented Jan 11, 2022

tony commented Jan 29, 2022

Window titles

tony commented Mar 4, 2018 •

edited

Loading

tony commented Mar 4, 2018 •

edited

Loading

tony commented Mar 4, 2018 •

edited

Loading

tony commented Jan 9, 2021 •

edited

Loading