Skip to content

Setting window_name: '' doesn't work #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ckt114 opened this issue Sep 22, 2022 · 4 comments
Closed

Setting window_name: '' doesn't work #822

ckt114 opened this issue Sep 22, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@ckt114
Copy link

ckt114 commented Sep 22, 2022

Step 1: Provide a summary of your problem

Setting window_name: '' doesn't make the window name empty.

Step 2: Provide tmuxp details

  • Include output of tmuxp debug-info
environment:
	dist: macOS-12.6-arm64-arm-64bit
	arch: arm64
	uname: Darwin; ctran0322mac; 21.6.0
	version: Darwin Kernel Version 21.6.0: Mon Aug 22 20:20:05 PDT 2022; root:xnu-8020.140.49~2/RELEASE_ARM64_T8101
-------------------------
python version: 3.10.6 (main, Aug 30 2022, 04:58:14) [Clang 13.1.6 (clang-1316.0.21.2.5)]
system PATH: /opt/homebrew/bin:/opt/homebrew/sbin:/opt/homebrew/bin:/opt/local/bin:/opt/local/sbin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin
tmux version: 3.3
libtmux version: 0.15.1
tmuxp version: 1.15.0
tmux path: /opt/homebrew/bin/tmux
tmuxp path: /opt/homebrew/Cellar/tmuxp/1.15.0/libexec/lib/python3.10/site-packages/tmuxp
shell: /bin/zsh

Step 3: Describe the problem:

Setting window_name: '' should make the window name empty. I know this can be done by removing #W from tmux but this should be supported. I have 9 windows that I use by indices only. I don't need the name of the window.

Steps to reproduce:

Observed Results:

  • What happened? This could be a description, log output, etc.
    The window name automatically taken from the last command executed.

Expected Results:

  • What did you expect to happen?
    The window name should be empty.
@tony tony added the bug Something isn't working label Sep 25, 2022
@tony
Copy link
Member

tony commented Sep 25, 2022

@trankchung Good catch

I think this makes sense to do a PR for. Would you like to?

@ckt114
Copy link
Author

ckt114 commented Sep 26, 2022

@tony Here's the PR into libtmux that fixes this.

tmux-python/libtmux#444

@tony
Copy link
Member

tony commented Sep 26, 2022

@trankchung thank you!

Is that test thing I asked for here okay?

P.S. can you sign the CLA?

P.P.S Like the profile icon of Tux!

tony added a commit to tmux-python/libtmux that referenced this issue Oct 2, 2022
#445 will address and additional issue where formats of empty
strings are potentially being filtered out as if they held no value.

In re: tmux-python/tmuxp#822
tony added a commit to tmux-python/libtmux that referenced this issue Oct 2, 2022
@tony tony closed this as completed in c4b9c5a Oct 2, 2022
@tony
Copy link
Member

tony commented Oct 2, 2022

@trankchung If you try tmuxp, v1.16.1, is anything different?

tony added a commit that referenced this issue Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants