Skip to content

Only use typing-extensions if necessary #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/libtmux/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,13 @@
)

if t.TYPE_CHECKING:
import sys
import types

from typing_extensions import TypeAlias
if sys.version_info >= (3, 10):
from typing import TypeAlias
else:
from typing_extensions import TypeAlias

DashLiteral: TypeAlias = t.Literal["-"]

Expand Down
9 changes: 7 additions & 2 deletions src/libtmux/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,20 @@
logger = logging.getLogger(__name__)

if t.TYPE_CHECKING:
import sys
import types
from collections.abc import Callable, Generator

from typing_extensions import Self

from libtmux.server import Server
from libtmux.session import Session
from libtmux.window import Window

if sys.version_info >= (3, 11):
from typing import Self
else:
from typing_extensions import Self


TEST_SESSION_PREFIX = "libtmux_"
RETRY_TIMEOUT_SECONDS = int(os.getenv("RETRY_TIMEOUT_SECONDS", 8))
RETRY_INTERVAL_SECONDS = float(os.getenv("RETRY_INTERVAL_SECONDS", 0.05))
Expand Down
7 changes: 6 additions & 1 deletion tests/legacy_api/test_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,15 @@
from libtmux._compat import LooseVersion

if t.TYPE_CHECKING:
import sys
from collections.abc import Callable

from _pytest.python_api import RaisesContext
from typing_extensions import TypeAlias

if sys.version_info >= (3, 10):
from typing import TypeAlias
else:
from typing_extensions import TypeAlias

VersionCompareOp: TypeAlias = Callable[
[t.Any, t.Any],
Expand Down
7 changes: 6 additions & 1 deletion tests/test_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,15 @@
from libtmux._compat import LooseVersion

if t.TYPE_CHECKING:
import sys
from collections.abc import Callable

from _pytest.python_api import RaisesContext
from typing_extensions import TypeAlias

if sys.version_info >= (3, 10):
from typing import TypeAlias
else:
from typing_extensions import TypeAlias

VersionCompareOp: TypeAlias = Callable[
[t.Any, t.Any],
Expand Down