Skip to content

test(test_capture_pane): Remove bashism(s) #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 5, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGES
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,12 @@ $ pip install --user --upgrade --pre libtmux

### Tests

_There will be more tests over the coming weeks and months to shore up
flakiness across shells and environments._

- Compatibility improvement for `test_capture_pane` and `env` (#452), credit:
@zappolowski!
- Remove more BASHisms from tests (#455)

## libtmux 0.15.9 (2022-10-30)

Expand Down
2 changes: 1 addition & 1 deletion src/libtmux/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ class tmux_cmd:

Equivalent to:

.. code-block:: bash
.. code-block:: console

$ tmux new-session -s my session

Expand Down
2 changes: 1 addition & 1 deletion tests/test_pane.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def test_capture_pane(session: Session) -> None:
session.new_window(
attach=True,
window_name="capture_pane",
window_shell=f"{env} PS1='$ ' bash --norc --noprofile",
window_shell=f"{env} PS1='$ ' sh",
)
pane = session.attached_window.attached_pane
assert pane is not None
Expand Down