Strict detection of tmux version via regex

[mdeguzis]

See: #396

This change uses a more precise regex method to grab the tmux version string, taking into account the many variations of tmux versions:

# tmux 3.3a · tmux 3.3 · tmux 3.2a · tmux 3.2 · tmux 3.1c · tmux 3.1b · tmux tmux.org 2.8

I tested my change locally with tmuxp as well:

[dev-dsk-deguzim-1a-fa82568b DeGuzim-Config]$ tmuxp freeze --force -f yaml --yes --quiet
Save to: /home/deguzim/.tmuxp/work.yaml [/home/deguzim/.tmuxp/work.yaml]: 
[dev-dsk-deguzim-1a-fa82568b DeGuzim-Config]$ cat ~/.tmuxp/work.yaml 
session_name: work
windows:
- focus: 'true'
  layout: 61a9,231x42,0,0[231x16,0,0{150x16,0,0,0,80x16,151,0,2},231x25,0,17,1]
  options: {}
  panes:
  - shell_command:
    - cd /local/home/deguzim/src/libtmux
    - zsh
  - shell_command:
    - cd /local/home/deguzim/src/tmuxp
    - zsh
  - focus: 'true'
    shell_command:
    - cd /local/home/deguzim/src/DeGuzim-Config
    - python3
  window_name: zsh

Testing with python3:

>>> ver = "tmux 1.8"
>>> import re
>>> re.search('[0-9]{1}.[0-9]', ver).group(0)
'2.8'

>>> ver = "tmux 2.3"
>>> re.search('[0-9]{1}.[0-9]', ver).group(0)
'2.3'

Regex 101 test: https://regex101.com/r/y7jsSJ/1

[CLAassistant]

All committers have signed the CLA.

[tony]

Looking good so far. Good catch and nice job.

1. We may want to test for get_version() test 3.2a and 3.2
2. I have a regex here: https://github.com/tmux-python/libtmux/blob/d4c9af5/tests/test_common.py#L32, interestingly I don't fetch the letter either

[tony]

What about line 561, wouldn't this lose access to the a in 3.2a?

[tony]

poetry run mypy .

libtmux/common.py:555: error: Item "None" of "Optional[Match[str]]" has no attribute "group"

This will need null-checks to handle empty matches. I haven't tested, but it'd be something like

Suggested change

	version = re.search('[0-9]{1}.[0-9]', proc.stdout[0]).group(0)
	match = re.search('[0-9]{1}.[0-9]', proc.stdout[0])
	assert match is not None
	version = match.group(0)

[tony]

@mdeguzis I will give your PR priority review if you have more commits

I can also take a stab at it (but would be happy if yours got in so you get credit!)

[mdeguzis]

I should be able to look at the comments this week and see what I can do.

[tony]

@mdeguzis That sounds fine!

[tony]

@mdeguzis Is this a PR you're still interested in?