Skip to content

Formatted date is not localized #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Guts opened this issue Mar 27, 2020 · 0 comments · Fixed by #22
Closed

Formatted date is not localized #21

Guts opened this issue Mar 27, 2020 · 0 comments · Fixed by #22

Comments

@Guts
Copy link
Contributor

Guts commented Mar 27, 2020

Reproduce

Lets' use the fixtures used in tests, just moving from nl to fr to see more obvious difference:

  1. set locale in config:
site_name: test gitrevisiondatelocalized_plugin
use_directory_urls: true

locale: fr

plugins:
    - search
    - git-revision-date-localized
  1. Serve site : mkdocs serve -f .\tests\basic_setup\mkdocs_locale.yml
  2. Date is not localized:

image

Expected result

image

Debug

The error is located in this line:

mkdocs-git-revision-date-localized-plugin/mkdocs_git_revision_date_localized_plugin/util.py

Line 81 in 2f8dc73

return self._date_formats(unix_timestamp)

Should pass the inherited locale:

return self._date_formats(unix_timestamp=unix_timestamp, locale=locale)
Guts added a commit to Guts/mkdocs-git-revision-date-localized-plugin that referenced this issue Mar 27, 2020
@Guts
Fix timvink#21
064f8b7
@Guts Guts mentioned this issue Mar 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use locale during date formatting Guts/mkdocs-git-revision-date-localized-plugin
1 participant
@Guts