Guides setup parameters before declaring key #5643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR to the RC fixes a mild annoyance of mine in guide behaviour.
Briefly, this PR restores the opportunity encode position and/or direction information into the key.
Elaborating some more: prior to #5483, guides had the opportunity to encode position/direction information in the key.
Since position/direction is now resolved at the
ggplot_gtable()stage, guide keys have no such opportunity anymore.By using the
Guide$setup_params()method before taking the key from the parameters, this opportunity is restored.I came across this while messing about with guide extensions, and while not crucial for the guides in ggplot2, it is nice to have for other guide extensions.