Code

Make position guides customizable#3398

Code

Merged

paleolimbot merged 31 commits intotidyverse:mastertidyverse/ggplot2:masterfrom

paleolimbot:issue-3322-pos-guide-custpaleolimbot/ggplot2:issue-3322-pos-guide-custCopy head branch name to clipboard

Sep 29, 2019

Commits

Commits on Jul 2, 2019

• add default position guide = waiver() for all position scale constructors, exclude position guides from the general guide building code

  paleolimbot

  committed
  1d788aa

  Copy full SHA for 1d788aa

• add guide option to sec axis

  paleolimbot

  committed
  422fcd3

  Copy full SHA for 422fcd3

• add a guide_axis constructor

  paleolimbot

  committed
  1d4daf0

  Copy full SHA for 1d4daf0

• add guide none and finish adding guide axis

  paleolimbot

  committed
  4a7e54e

  Copy full SHA for 4a7e54e

• add methods to get guides, layers, and mapping into the coords

  paleolimbot

  committed
  0496e55

  Copy full SHA for 0496e55

• guide_axis() objects mostly work with coord_cartesian()

  paleolimbot

  committed
  0c0c01a

  Copy full SHA for 0c0c01a

Commits on Jul 3, 2019

• fix breaks that are outside the scale limits

  paleolimbot

  committed
  8215477

  Copy full SHA for 8215477

• fix second axes

  paleolimbot

  committed
  d6c35c7

  Copy full SHA for d6c35c7

• fix new axis guides with coord_flip()

  paleolimbot

  committed
  1f092f2

  Copy full SHA for 1f092f2

• this PR uses a different method to calculate the positions of ticks (coord$transform() vs. arbitrarily rescaling using the limits)

  paleolimbot

  committed
  1281280

  Copy full SHA for 1281280

• pass on customizations to the draw method, add tests

  paleolimbot

  committed
  c0bc334

  Copy full SHA for c0bc334

Commits on Jul 4, 2019

• fix specification of guides in guides(), warn if guide might be in an inappropriate position

  paleolimbot

  committed
  6244983

  Copy full SHA for 6244983

• make guide_transform() generic

  paleolimbot

  committed
  50ef6f5

  Copy full SHA for 50ef6f5

• add ability for (in theory) multiple axes to be drawn at one panel location

  paleolimbot

  committed
  2b2f4fb

  Copy full SHA for 2b2f4fb

Commits on Jul 5, 2019

• issue a warning when more than one guide exists for one panel location

  paleolimbot

  committed
  4a45706

  Copy full SHA for 4a45706

• ensure that user-facing messages refer to "position guides"

  paleolimbot

  committed
  f91a546

  Copy full SHA for f91a546

• rename guides_grob to make it more specific

  paleolimbot

  committed
  7c435ae

  Copy full SHA for 7c435ae

• add ability for guides to have titles

  paleolimbot

  committed
  e9358ed

  Copy full SHA for e9358ed

• fix title parameter documentation for position guides

  paleolimbot

  committed
  8942c56

  Copy full SHA for 8942c56

• remove unused method

  paleolimbot

  committed
  e060347

  Copy full SHA for e060347

Commits on Jul 17, 2019

• implement hadley's review suggestions

  paleolimbot

  committed
  b05111a

  Copy full SHA for b05111a

• clarify position guide resolving code

  paleolimbot

  committed
  5e5d748

  Copy full SHA for 5e5d748

Commits on Aug 28, 2019

• fix guide_none() with non-position scales

  paleolimbot

  committed
  2d040c7

  Copy full SHA for 2d040c7

• rename n_dodge to n.dodge

  paleolimbot

  committed
  b52fa59

  Copy full SHA for b52fa59

• remove "none" guides before calculating grobs

  paleolimbot

  committed
  2ef4fe1

  Copy full SHA for 2ef4fe1

• fix multiple guide logic and warning

  paleolimbot

  committed
  f11609a

  Copy full SHA for f11609a

• ensure guide_legend fails properly when used with position scales

  paleolimbot

  committed
  b738de5

  Copy full SHA for b738de5

• fix axis plural

  paleolimbot

  committed
  0cc850e

  Copy full SHA for 0cc850e

Commits on Sep 22, 2019

• add comment reminding to use find_global() when guides are officially extensible

  paleolimbot

  committed
  92e16ae

  Copy full SHA for 92e16ae

Commits on Sep 29, 2019

• add NEWS bullet

  paleolimbot

  committed
  f930075

  Copy full SHA for f930075

• Merge branch 'master' into issue-3322-pos-guide-cust

  paleolimbot

  authored
  6448aa0

  Copy full SHA for 6448aa0