Skip to content

Remove smart quotes #3051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 27, 2018

Conversation

yutannihilation
Copy link
Member

For so so long, I've been wondering why devtools::document() fails on my Windows if I don't change my locale to C:

==> devtools::document(roclets = c('rd', 'collate', 'namespace'))

Updating ggplot2 documentation
Writing NAMESPACE
Loading ggplot2
Writing aes_group_order.Rd
Error in gsub("\n", "\r\n", contents, fixed = TRUE) : 
  input string 1 is invalid in this locale
Calls: suppressPackageStartupMessages ... roclet_output.roclet_rd -> mapply -> <Anonymous> -> same_contents -> gsub
Execution halted

Exited with status 1.

But, at last, I found the cause! Let's say goodbye to LEFT SINGLE QUOTATION MARK (U+2018) and RIGHT SINGLE QUOTATION MARK (U+2019).

@yutannihilation yutannihilation merged commit e9d4e5d into tidyverse:master Dec 27, 2018
@yutannihilation yutannihilation deleted the fix-smart-quote branch December 27, 2018 10:54
@lock
Copy link

lock bot commented Jun 26, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jun 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants