Use .ignore_empty="all" for enquos() #2936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutannihilation
commented
Oct 12, 2018
tests/testthat/test-aes.r
Outdated
| @@ -89,7 +89,7 @@ test_that("assignment methods pull unwrap constants from quosures", { | |||
| }) | |||
|
|
|||
| test_that("quosures are squashed when creating default label for a mapping", { | |||
| p <- ggplot(mtcars) + aes(!!quo(identity(!!quo(cyl)))) | |||
| p <- ggplot(mtcars) + aes(!!rlang::quo(identity(!!rlang::quo(cyl)))) | |||
There was a problem hiding this comment.
I don't know why this matters, but if I use .ignore_empty = "all", this fails...
yutannihilation
changed the title
yutannihilation
force-pushed
the
use-ignore-empty-all
branch
from
2a5cac9 to
3e538c2
Compare
|
Thanks for reviewing! |
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw
aes()is mentioned here: r-lib/rlang#643. It saysenquos()will get"all"option for.ignore_empty, which ignores named missing arguments as well, in rlang v0.3.0 . This PR uses it to simplify the code.Besides, r-lib/rlang#430 seems fixed, so the workaround is no longer needed.