Add Vue Testing Library types from DefinitelyTyped #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afontcu
changed the title
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 63 63
Branches 10 10
=====================================
Hits 63 63Continue to review full report at Codecov.
|
alexkrolick
approved these changes
Aug 18, 2019
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #84
Following the strategy outlined here testing-library/react-testing-library#437, I'm adding VTL types as a dependency.
This means that people installing
@testing-library/vuewould get@types/testing-library__vueinstalled automatically. So from the developers point of view, it's as though the type definitions shipped with the package directly. (adapted from here).