Skip to content

Improve onboarding by adding explanations #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 21, 2019
Merged

Improve onboarding by adding explanations #43

merged 9 commits into from
Jun 21, 2019

Conversation

afontcu
Copy link
Member

@afontcu afontcu commented Jun 10, 2019

  • Bumped DOM Testing Library, so now we can demo the new capabilities of *byRole queries (Add semantic HTML elements implicit role support to queryByRole/getByRole selectors dom-testing-library#262).
  • Renamed tests to express feature under testing, instead of component details. When I started working with VTL, I had a hard time trying to remember where specific examples were. I feel that expressing the testing intent in the filename will help.
  • Added comments to provide a better onboarding experience with the library.
  • Removed unused component files.

As usual, feel free to suggest any modification or clarification :)

Thanks!

@afontcu afontcu requested a review from dfcook June 10, 2019 18:10
@afontcu
Copy link
Member Author

afontcu commented Jun 21, 2019

Since this is far from any breaking change, I'm gonna merge it, and feel free to suggest any additional modification later :)

@afontcu afontcu merged commit f7bb066 into testing-library:master Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant