Skip to content

Feature/scoped packages #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 31, 2019
Merged

Feature/scoped packages #29

merged 8 commits into from
May 31, 2019

Conversation

dfcook
Copy link
Collaborator

@dfcook dfcook commented May 31, 2019

Move the library to use scoped packages

@afontcu
Copy link
Member

afontcu commented May 31, 2019

Given the name change, should src/vue-testing-library.js be renamed and (test files updated accordingly) as in #26? The goal of that PR was to import the library the same way any user would, so I guess test files should be updated to import {...} from '@testing-library/vue.

Not sure how Jest handles scoped packages, though. But happy to look into that if you think that'd help. I guess the index file could be renamed to index.js again, and map "@testing-library/vue" to it.

@dfcook
Copy link
Collaborator Author

dfcook commented May 31, 2019

That makes sense, I'm holding back merging this in as currently unable to publish the scoped package on npm (have a ticket out for that).

If you want to take a look at fixing either of the issues you raised in the meantime I'd be happy to accept PR's for those. I'd get to them eventually but work issues have meant I haven't spent as much time working on this as I'd like recently.

@dfcook dfcook merged commit 2dfe92e into master May 31, 2019
@dfcook dfcook deleted the feature/scoped-packages branch June 1, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants