feat: allow passing instantiated Vue Router #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 99 99
Branches 33 34 +1
=========================================
Hits 99 99
Continue to review full report at Codecov.
|
This was referenced Jun 29, 2021
afontcu
requested changes
Jun 29, 2021
|
Thanks for this! I left a comment regarding the test, but it looks good overall :) |
blimmer
force-pushed
the
allow-passing-instantiated-router
branch
from
0f4b6f8 to
70313ae
Compare
|
🎉 This PR is included in version 5.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 6.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #238 and is similar to #232. If
routesis an instantiated Vue Router, it will be used instead of creating a new Vue Router. This allows developers to useabstractmode to avoid the issue described in #210.Fixes #210
See also docs upates here: testing-library/testing-library-docs#875