-
Notifications
You must be signed in to change notification settings - Fork 111
chore: Cleanup structure #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
afontcu
commented
Feb 17, 2021
- Split large main file into smaller, focused ones.
- Bump deps.
Codecov Report
@@ Coverage Diff @@
## master #209 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 3 +2
Lines 100 99 -1
Branches 34 33 -1
=========================================
- Hits 100 99 -1
Continue to review full report at Codecov.
|
// event loop tick to allow Vue to flush and update the DOM | ||
// More info: https://vuejs.org/v2/guide/reactivity.html#Async-Update-Queue | ||
|
||
async function fireEvent(...args) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question out of curiosity. when using VTL, should we always use the fireEvent
exported by this library or instead should we use user-event
? with RTL, user-event is suggested https://kentcdodds.com/blog/common-mistakes-with-react-testing-library#not-using-testing-libraryuser-event
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi! Using user-event is advisable, as it is closer to the user. We even showcase some examples: https://github.com/testing-library/vue-testing-library/blob/master/src/__tests__/user-event.js
🎉 This PR is included in version 5.6.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 6.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |