Fix vuetify example #134
Merged
Fix vuetify example #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update with remote origin
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 68 68
Branches 14 14
=========================================
Hits 68 68 Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 5.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #123 I introduced a different approach to integrate with Vuetify. Unfortunately
setAttributealways returns undefined, socontainereventually was undefined.In my own project this lead to bespoken
Unable to localte target [data-app]warnings when rendering certain vuetify components, such asv-menuorv-dialog. In this example that went unnoticed, because the example component itself was wrapped withinv-app.I fixed that and added tests for it.
A sidenote: In my own project, adding the container to the body(
document.body.appendChild(root)) lead to side-effects when interacting withv-menu. It seemed like the component was leaking between tests. Even with Jest running as--runInBand. However it doesn't happen in this repo. So for this, I am lost 😒. Indeed if I copy paste this test and the tested component over to my project, it fails because it cannot find the openedmenu item:/