Skip to content

allow vue-router creation through routes param from both jest and mocha (fix) #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 18, 2020

Conversation

agualis
Copy link
Contributor

@agualis agualis commented Mar 18, 2020

No description provided.

@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #128 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #128   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           67        68    +1     
  Branches        14        14           
=========================================
+ Hits            67        68    +1     
Impacted Files Coverage Δ
src/vue-testing-library.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58a4b5a...2286149. Read the comment docs.

@agualis
Copy link
Contributor Author

agualis commented Mar 18, 2020

Hey, this is embarrassing 😓 I tested the released version in my mocha project and it did not work cause there was a mistake in my code. I updated it again. Sorry for the inconvenience.

You will also notice that I deleted the mocha test as it was based in my wrong assumption that the require import would be undefined. With the new code, that won't affect the coverage though.

@afontcu
Copy link
Member

afontcu commented Mar 18, 2020

Hi! No worries 😃 Releasing a new patch version ASAP

@afontcu afontcu merged commit d628f36 into testing-library:master Mar 18, 2020
@afontcu
Copy link
Member

afontcu commented Mar 18, 2020

🎉 This PR is included in version 5.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@agualis
Copy link
Contributor Author

agualis commented Mar 18, 2020

That was blazing fast 🚀 I confirm that now Router works in mocha. You rock!

@afontcu
Copy link
Member

afontcu commented Mar 18, 2020

you do! thanks for doing this 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants