-
Notifications
You must be signed in to change notification settings - Fork 111
allow vue-router creation through routes param from both jest and mocha (fix) #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 67 68 +1
Branches 14 14
=========================================
+ Hits 67 68 +1
Continue to review full report at Codecov.
|
Hey, this is embarrassing 😓 I tested the released version in my mocha project and it did not work cause there was a mistake in my code. I updated it again. Sorry for the inconvenience. You will also notice that I deleted the mocha test as it was based in my wrong assumption that the require import would be undefined. With the new code, that won't affect the coverage though. |
Hi! No worries 😃 Releasing a new patch version ASAP |
🎉 This PR is included in version 5.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
That was blazing fast 🚀 I confirm that now Router works in mocha. You rock! |
you do! thanks for doing this 🙌 |
No description provided.