add simple directive and test #110
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afontcu
reviewed
Nov 4, 2019
| import {value as valueDirective} from './components/directives/v-value' | ||
| import CompWithDirective from './components/CompWithDirective.vue' | ||
|
|
||
| test('element should have the same value as the directive', async () => { |
There was a problem hiding this comment.
I feel the example is a bit "wordy" (it says value a lot 😝).
I think it would be best if we used a simpler example with a clearer directive. Also I'd love to avoid using updateProps, as it has actually nothing to do with directives, and people may get the wrong impression.
What do you think about that?
|
this was closed because I referenced it in #111, I'll fix the issues and reopen |
|
Hi @chiptus! Any chance you could take a look at this? 😄 have a happy new year! |
Co-Authored-By: Adrià Fontcuberta <[email protected]>
|
will do |
|
Fixed in #120. Thanks for this, though! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #108