Skip to content

Set Vue as a peerDependency? #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
afontcu opened this issue Jul 19, 2019 · 1 comment
Closed

Set Vue as a peerDependency? #61

afontcu opened this issue Jul 19, 2019 · 1 comment

Comments

@afontcu
Copy link
Member

afontcu commented Jul 19, 2019

And same think with vue-template-compiler (required by vue-test-utils).

We should be using Vue's version provided by the project where VTL is running. Both libraries should be added as a devDependency too.

I guess that'd could be considered a breaking change..?

Any thoughts? Am I missing something? RTL is doing the same thing.
@afontcu afontcu changed the title Set Vue as a peerDependency Set Vue as a peerDependency? Jul 19, 2019
dfcook added a commit that referenced this issue Jul 30, 2019
@dfcook
#61 - set vue as a peer dependency
e553082
@afontcu
Copy link
Member Author

afontcu commented Jul 30, 2019

Closed in #64

@afontcu afontcu closed this as completed Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@afontcu