Skip to content

Provide a cleanup-after-each file? #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
afontcu opened this issue May 29, 2019 · 3 comments
Closed

Provide a cleanup-after-each file? #27

afontcu opened this issue May 29, 2019 · 3 comments

Comments

@afontcu
Copy link
Member

afontcu commented May 29, 2019

Hi! react-testing-library is providing a cleanup-after-each file that comes in handy to avoid repeating afterEach(cleanup) on every test file. They even load it using a setup file, so you load it once and forget about dirty DOM nodes once for all.

Would it make sense to port this feature to vue-testing-library? If so, I'd happily submit a PR with both the file and the required documentation 🤗

👋
dfcook added a commit that referenced this issue Jun 1, 2019
@dfcook
#27 - Provide cleanup-after-each
532a800
@dfcook
Copy link
Collaborator

dfcook commented Jun 1, 2019

Would appreciate thoughts on the PR for this

dfcook added a commit that referenced this issue Jun 1, 2019
@dfcook
Merge pull request #31 from testing-library/issue/27-cleanup-after-each
1367d61 
#27 - Provide cleanup-after-each
@afontcu
Copy link
Member Author

afontcu commented Jun 1, 2019

Done! 🎉

@afontcu afontcu closed this as completed Jun 1, 2019
@dfcook
Copy link
Collaborator

dfcook commented Jun 1, 2019

Released in 1.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@afontcu @dfcook