Skip to content

Unexpected parameter format for rerender() - v6 (next) #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Jan 8, 2021 · 2 comments
Closed

Unexpected parameter format for rerender() - v6 (next) #197

ghost opened this issue Jan 8, 2021 · 2 comments

Comments

@ghost
Copy link

ghost commented Jan 8, 2021

Hi,
The rerender function's signature on v6 is:

rerender(props: object): Promise<void>

But this is how it works:

rerender({ props: { error: false } })

I think the props key is redundant and misleading here and it needs to be something like:

rerender({ error: false })
@ghost ghost added the bug Something isn't working label Jan 8, 2021
@afontcu afontcu added vue3 and removed bug Something isn't working labels Jan 8, 2021
@afontcu
Copy link
Member

afontcu commented Jan 8, 2021

Hey! Yeah, I agree that it looks weird and that rerender({ error: false }) makes more sense.

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

🎉 This issue has been resolved in version 6.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant