Skip to content

docs: Fix broken link #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2021
Merged

docs: Fix broken link #761

merged 1 commit into from
Feb 16, 2021

Conversation

chartrandf
Copy link
Contributor

Fix a broken link on this page : https://testing-library.com/docs/queries/bytext/

When clicking on the following it's redirecting to a 404.

Capture d’écran, le 2021-02-15 à 16 12 37

@chartrandf chartrandf changed the title [Doc] Fix broken link docs: Fix broken link Feb 15, 2021
@MatanBobi
Copy link
Member

Hi @chartrandf!
Thanks for taking the time to open this :)
In the preview it still looks like that link is broken:
https://deploy-preview-761--testing-library.netlify.app/

I believe it's because you're missing the file's suffix (.mdx).
This sometimes works on localhost but not in the production build :)
Can you please fix that?

@chartrandf
Copy link
Contributor Author

Hi @chartrandf!
Thanks for taking the time to open this :)
In the preview it still looks like that link is broken:
https://deploy-preview-761--testing-library.netlify.app/

I believe it's because you're missing the file's suffix (.mdx).
This sometimes works on localhost but not in the production build :)
Can you please fix that?

Ohh yes sorry, it should be fine now 😄

MatanBobi
MatanBobi approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@MatanBobi MatanBobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep it's working now.
Thanks @chartrandf!

@MatanBobi MatanBobi merged commit 074a5b5 into testing-library:master Feb 16, 2021
@MatanBobi
Copy link
Member

@all-contributors please add @chartrandf for docs :)

@allcontributors allcontributors bot mentioned this pull request Feb 16, 2021
Merged
@allcontributors
Copy link
Contributor

@MatanBobi

I've put up a pull request to add @chartrandf! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatanBobi MatanBobi MatanBobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chartrandf @MatanBobi