Skip to content

Update angular api #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 24, 2024
Merged

Update angular api #1413

merged 3 commits into from
Aug 24, 2024

Conversation

timdeschryver
Copy link
Member

@timdeschryver timdeschryver commented Aug 22, 2024

Update the Angular API:

  • mark properties as deprecated
  • document new properties

Closes testing-library/angular-testing-library#476
Closes testing-library/angular-testing-library#467

Copy link

netlify bot commented Aug 22, 2024

Deploy Preview for testing-library ready!

Name Link
🔨 Latest commit f549e57
🔍 Latest deploy log https://app.netlify.com/sites/testing-library/deploys/66c779d7385eeb0008426b7c
😎 Deploy Preview https://deploy-preview-1413--testing-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@MatanBobi MatanBobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 😀
Do you think we should maybe add the version number from where the new APIs are available or is that common knowledge?

@timdeschryver
Copy link
Member Author

Looks good 😀 Do you think we should maybe add the version number from where the new APIs are available or is that common knowledge?

It's new API's in Angular Testing Library. I don't want to add version numbers and keep the docs to the latest version. Otherwise it can become messy imho 😅.

@MatanBobi
Copy link
Member

It's new API's in Angular Testing Library. I don't want to add version numbers and keep the docs to the latest version. Otherwise it can become messy imho 😅.

No worries, it was just an idea 😀

@timdeschryver timdeschryver merged commit 9f0b530 into main Aug 24, 2024
4 checks passed
@timdeschryver timdeschryver deleted the update-angular-api branch August 24, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docs for inputs (and aliasedInput) Add docs for on
2 participants