Skip to content

chore: update vue api doc to match implementation #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 17, 2022
Merged

chore: update vue api doc to match implementation #1141

merged 2 commits into from
Aug 17, 2022

Conversation

davidnixon
Copy link
Contributor

@netlify
Copy link

netlify bot commented Aug 16, 2022 •
edited
Loading

✅ Deploy Preview for testing-library ready!

Name Link
🔨 Latest commit b9d6941
🔍 Latest deploy log https://app.netlify.com/sites/testing-library/deploys/62fd1201b88188000821fbdc
😎 Deploy Preview https://deploy-preview-1141--testing-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@davidnixon davidnixon mentioned this pull request Aug 16, 2022
Closed
afontcu
afontcu requested changes Aug 17, 2022
View reviewed changes
Copy link
Member

@afontcu afontcu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this!! 🙌 I left some comments here and there

afontcu
afontcu approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@afontcu afontcu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! 🤩

@afontcu afontcu merged commit c3cbff3 into testing-library:main Aug 17, 2022
@afontcu
Copy link
Member

afontcu commented Aug 17, 2022

@all-contributors please add @davidnixon for docs

@allcontributors allcontributors bot mentioned this pull request Aug 17, 2022
Merged
@allcontributors
Copy link
Contributor

@afontcu

I've put up a pull request to add @davidnixon! 🎉

@rydash rydash mentioned this pull request Mar 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afontcu afontcu afontcu approved these changes

@timdeschryver timdeschryver timdeschryver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidnixon @afontcu @timdeschryver