Skip to content

docs(react-router): fixes react router v6 examples, removes outdated comments #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

shaiRose
Copy link
Contributor

@shaiRose shaiRose commented Jul 5, 2022

docs(react-router): fixes react router v6 examples, removes outdated comments
closes #1065

Details

@MatanBobi MatanBobi linked an issue Jul 5, 2022 that may be closed by this pull request
Copy link
Member

@MatanBobi MatanBobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for taking the time on this one :)

@MatanBobi MatanBobi merged commit 107faec into testing-library:main Jul 5, 2022
@MatanBobi
Copy link
Member

@all-contributors please add @shaiRose for docs :)

@allcontributors
Copy link
Contributor

@MatanBobi

I've put up a pull request to add @shaiRose! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React router not navigating to new page inside test Possible error in an example - confusion between react router 5 & 6
3 participants