-
Notifications
You must be signed in to change notification settings - Fork 728
Clarifying user-event's capabilities vs fire-event #1102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You should use Like with every other software there are limitations. Regarding |
@ph-fritsche thanks for the comment!
Yes, I totally understand this - my last PR for this repo actually resulted in the text you're quoting.
This is the point that I think would be helpful to make clearer - that What's frustrating about the current phrasing is that it makes it sound like you should be able to test all user interactions via This leads to devs wasting time trying to figure out how to get |
Implementing CR suggestion Co-authored-by: Philipp Fritsche <[email protected]>
Great suggestions, @ph-fritsche - I implemented both of them. Feel free to tweak the wording, I just put in exactly what you suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM.
Leaving this for @ph-fritsche for a final review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added missing backticks
Thanks for helping us improve the docs @meatnordrink ❤️ |
The current intro makes it sounds like
user-event
can test all valid user interactions, and is a replacement forfire-event
in all user-interaction cases. However, in our engineering dept., we've found that this is not the case. For example, to pick a specific value on a slider, we use:We haven't been able to find any
user-event
equivalent to this. So unless there's something we're not aware of (and we've posted the question to SO and received no responses), then noting thatuser-event
can not replacefire-event
in all cases would improve the clarity and usefulness of theuser-event
intro.